Merge pull request #53311 from geoand/#37483

Log cause of HTTP 400 by default in dev and test mode

Author: geoand

extensions/resteasy-reactive/rest/deployment/src/main/java/io/quarkus/resteasy/reactive/server/deployment/ResteasyReactiveProcessor.java

@@ -70,6 +70,7 @@
 import org.jboss.jandex.MethodInfo;
 import org.jboss.jandex.Type;
 import org.jboss.logging.Logger;
+import org.jboss.logmanager.Level;
 import org.jboss.resteasy.reactive.common.core.Serialisers;
 import org.jboss.resteasy.reactive.common.core.SingletonBeanFactory;
 import org.jboss.resteasy.reactive.common.model.InjectableBean;
@@ -99,6 +100,7 @@
 import org.jboss.resteasy.reactive.server.core.DeploymentInfo;
 import org.jboss.resteasy.reactive.server.core.ExceptionMapping;
 import org.jboss.resteasy.reactive.server.core.ServerSerialisers;
+import org.jboss.resteasy.reactive.server.handlers.ParameterHandler;
 import org.jboss.resteasy.reactive.server.handlers.RestInitialHandler;
 import org.jboss.resteasy.reactive.server.model.ContextResolvers;
 import org.jboss.resteasy.reactive.server.model.DelegatingServerRestHandler;
@@ -151,6 +153,7 @@
 import io.quarkus.deployment.builditem.FeatureBuildItem;
 import io.quarkus.deployment.builditem.GeneratedClassBuildItem;
 import io.quarkus.deployment.builditem.LaunchModeBuildItem;
+import io.quarkus.deployment.builditem.LogCategoryBuildItem;
 import io.quarkus.deployment.builditem.RecordableConstructorBuildItem;
 import io.quarkus.deployment.builditem.ShutdownContextBuildItem;
 import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
@@ -299,6 +302,14 @@ MethodScannerBuildItem responseHeaderSupport() {
         return new MethodScannerBuildItem(new ResponseHeaderMethodScanner());
     }
 
+    @BuildStep
+    void configureLogLevels(BuildProducer<LogCategoryBuildItem> producer, LaunchModeBuildItem launchMode) {
+        if (!launchMode.getLaunchMode().isDevOrTest()) {
+            return;
+        }
+        producer.produce(new LogCategoryBuildItem(ParameterHandler.class.getName(), Level.DEBUG));
+    }
+
     @BuildStep
     void vertxIntegration(BuildProducer<MessageBodyWriterBuildItem> writerBuildItemBuildProducer) {
         writerBuildItemBuildProducer.produce(new MessageBodyWriterBuildItem(ServerVertxBufferMessageBodyWriter.class.getName(),

extensions/resteasy-reactive/rest/deployment/src/test/java/io/quarkus/resteasy/reactive/server/test/ParameterHandlerDebugLogTest.java

@@ -0,0 +1,55 @@
+package io.quarkus.resteasy.reactive.server.test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.util.logging.LogRecord;
+import java.util.stream.Collectors;
+
+import jakarta.ws.rs.GET;
+import jakarta.ws.rs.HeaderParam;
+import jakarta.ws.rs.Path;
+
+import org.jboss.logmanager.Level;
+import org.jboss.resteasy.reactive.server.handlers.ParameterHandler;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.test.QuarkusExtensionTest;
+import io.restassured.RestAssured;
+
+/**
+ * Verifies that parameter conversion errors are logged at DEBUG level in dev/test mode,
+ * so that the root cause of HTTP 400 responses is visible without manual log configuration.
+ */
+public class ParameterHandlerDebugLogTest {
+
+    @RegisterExtension
+    static QuarkusExtensionTest test = new QuarkusExtensionTest()
+            .withApplicationRoot(jar -> jar.addClasses(TestResource.class))
+            .setLogRecordPredicate(record -> record.getLoggerName().equals(ParameterHandler.class.getName())
+                    && record.getLevel().equals(Level.DEBUG))
+            .assertLogRecords(records -> {
+                var messages = records.stream().map(LogRecord::getMessage).collect(Collectors.toList());
+                assertThat(messages).anySatisfy(msg -> assertThat(msg).contains("Unable to handle parameter"));
+            });
+
+    @Test
+    public void testBadHeaderParamLogsDebug() {
+        RestAssured
+                .given()
+                .header("X-Number", "not-a-number")
+                .get("/test/header")
+                .then()
+                .statusCode(400);
+    }
+
+    @Path("/test")
+    public static class TestResource {
+
+        @GET
+        @Path("/header")
+        public String header(@HeaderParam("X-Number") int number) {
+            return "number=" + number;
+        }
+    }
+}