panache-data-rest : common default methods in interfaces

[akil-rails]

panache-data-rest is great, helps avoid a lot of repeated code, and we are using it extensively.

there are some methods that we want to add across all resource interfaces, but at this time, we have to write these manually in all interfaces, since extending 2 interfaces isn't allowed, there's a specific validation in the build step as seen below

is there any reason why this exists, what would be a way to add common methods across all our interfaces ?

    private void validateResource(IndexView index, ClassInfo classInfo) {
        if (!Modifier.isInterface(classInfo.flags())) {
            throw new RuntimeException(classInfo.name() + " has to be an interface");
        }

        if (classInfo.interfaceNames().size() > 1) {
            throw new RuntimeException(classInfo.name() + " should only extend REST Data Panache interface");
        }

        if (!index.getKnownDirectImplementors(classInfo.name()).isEmpty()) {
            throw new RuntimeException(classInfo.name() + " should not be extended or implemented");
        }
    }

[quarkus-bot[bot]]

/cc @FroMage (panache), @loicmathieu (panache)

[FroMage]

The reason is mostly that it was never needed and it would make the code more complicated. That's all.

But it's a good idea. Do you feel like providing a PR for this? We can help you :)

[akil-rails]

Yes, how do we get started on this? I mean what is the complication that needs to be addressed ?

[akil-rails]

We have a similar situation with the RestDataResourceMethodListener

We have something like the following:

public class DraftAwareResourceMethodListener implements RestDataResourceMethodListener<DraftAwareEntity> {

  @Inject
  DraftAwareEntityRepository repository;

  @Override
  public void onBeforeAdd(DraftAwareEntity entity) {
  }

  @Override
  public void onBeforeUpdate(DraftAwareEntity entity) {
  }

  @Override
  public void onBeforeDelete(Object id) {
  }
}

The onBeforeDelete receives the ID , and not the entity & neither the resource class, so its impossible to share a onBeforeDelete across resources, while onBeforeAdd and onBeforeUpdate can be shared.