BlockingRedisDataSourceImpl doesn't call DISCARD if consumer function throws an exception

[luca-bassoricci]

In BlockingRedisDataSourceImpl#withTransaction() if the call to BiConsumer<I, TransactionalRedisDataSource> tx throws an exception DISCARD command is not issued left redis in a stale state.
Is this the expected flow?
Would be a good idea to try/catch tx.accept() call and send DISCARD from BlockingRedisDataSourceImpl#withTransaction() if TransactionalRedisDataSource#discard() has not been called?

Pseudo

try {
  tx.accept(t, u);
}
catch (Throwable e)  {
  if(!u.discarded())  {
    u.discard();
  }
}

Looking at ReactiveRedisDataSourceImpl it sends a DISCARD command in case of failure.

Thanks
Luca.

[quarkus-bot[bot]]

/cc @Ladicek (redis), @cescoffier (redis), @machi1990 (redis)

[Ladicek]

This seems sensible. It turns out that out of 3 withTransaction() methods in ReactiveRedisDataSourceImpl, only 2 of them automatically send DISCARD. BlockingRedisDataSourceImpl doesn't send DISCARD in either of the 3 withTransaction() methods.

I don't know if there's a difference between these methods, but I don't think so, at least when it comes to which of them should/shouldn't automatically send DISCARD. They should be consistent in this regard.

[Ladicek]

Created #49531 out of this discussion.