refactor: simplify lint_string_wrapped API and clean up related tests

Author: gvozdvmozgu

Cargo.toml

@@ -17,12 +17,12 @@ perf = "warn"
 cloned_instead_of_copied = "warn"
 
 # https://github.com/rustwasm/wasm-bindgen/issues/3451#issuecomment-1562982835
-[profile.dev]
-opt-level = "s"
+#[profile.dev]
+#opt-level = "s"
 
-[profile.release]
-lto = true
-codegen-units = 1
+#[profile.release]
+#lto = true
+#codegen-units = 1
 
 [workspace.dependencies]
 ahash = { version = "0.8.11", features = ["compile-time-rng", "serde"] }

crates/lib/src/core/linter/core.rs

@@ -75,12 +75,9 @@ impl Linter {
     }
 
     /// Lint strings directly.
-    pub fn lint_string_wrapped(&mut self, sql: &str, fix: bool) -> LintingResult {
+    pub fn lint_string_wrapped(&mut self, sql: &str, fix: bool) -> LintedFile {
         let filename = "<string input>".to_owned();
-
-        let mut result = LintingResult::new();
-        result.add(self.lint_string(sql, Some(filename), fix));
-        result
+        self.lint_string(sql, Some(filename), fix)
     }
 
     /// Parse a string.

crates/lib/src/templaters/placeholder.rs

@@ -356,7 +356,6 @@ Also consider making a pull request to the project to have your style added, it
 
 #[cfg(test)]
 mod tests {
-    use std::mem::take;
 
     use super::*;
     use crate::core::linter::core::Linter;
@@ -796,8 +795,7 @@ param_style = percent
         let sql = "SELECT a,b FROM users WHERE a = %s";
 
         let mut linter = Linter::new(config, None, None, false);
-        let mut result = linter.lint_string_wrapped(sql, true);
-        let result = take(&mut result.files[0]).fix_string();
+        let result = linter.lint_string_wrapped(sql, true).fix_string();
 
         assert_eq!(result, "SELECT\n    a,\n    b\nFROM users WHERE a = %s\n");
     }

crates/lib/tests/rules.rs

@@ -214,16 +214,14 @@ dialect = {dialect}
                         pass_str = pass_str
                     );
 
-                    assert_eq!(&f.files[0].violations, &[], "{}", error_string);
+                    assert_eq!(&f.violations, &[], "{}", error_string);
                 }
                 TestCaseKind::Fail { fail_str } => {
                     let f = linter.lint_string_wrapped(&fail_str, false);
-                    assert_ne!(&f.files[0].violations, &[])
+                    assert_ne!(&f.violations, &[])
                 }
                 TestCaseKind::Fix { fail_str, fix_str } => {
-                    let f =
-                        std::mem::take(&mut linter.lint_string_wrapped(&fail_str, true).files[0])
-                            .fix_string();
+                    let f = linter.lint_string_wrapped(&fail_str, true).fix_string();
 
                     pretty_assertions::assert_eq!(f, fix_str);
                 }