Skip to content

Commit 5aacc03

Browse files
authored
fix: x/feemarket (#836)
## 1. Overview - v1.0.x had a bug that was not prededucting fees - this fix updates wiring and bumps version - refer [this](cosmos/gaia@92a2a88).
1 parent 2c99fbf commit 5aacc03

File tree

5 files changed

+26
-18
lines changed

5 files changed

+26
-18
lines changed

ante/ante.go

+14-1
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,21 @@
11
package ante
22

33
import (
4+
storetypes "cosmossdk.io/store/types"
45
feemarketante "github.com/skip-mev/feemarket/x/feemarket/ante"
56
feemarketkeeper "github.com/skip-mev/feemarket/x/feemarket/keeper"
67

8+
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
79
ibcante "github.com/cosmos/ibc-go/v8/modules/core/ante"
810
ibckeeper "github.com/cosmos/ibc-go/v8/modules/core/keeper"
911

1012
corestoretypes "cosmossdk.io/core/store"
1113
errorsmod "cosmossdk.io/errors"
1214

15+
txsigning "cosmossdk.io/x/tx/signing"
1316
"github.com/cosmos/cosmos-sdk/codec"
1417
sdk "github.com/cosmos/cosmos-sdk/types"
18+
"github.com/cosmos/cosmos-sdk/types/tx/signing"
1519
"github.com/cosmos/cosmos-sdk/x/auth/ante"
1620
stakingkeeper "github.com/cosmos/cosmos-sdk/x/staking/keeper"
1721

@@ -27,7 +31,13 @@ var UseFeeMarketDecorator = true
2731
// HandlerOptions extend the SDK's AnteHandler options by requiring the IBC
2832
// channel keeper.
2933
type HandlerOptions struct {
30-
ante.HandlerOptions
34+
ExtensionOptionChecker ante.ExtensionOptionChecker
35+
FeegrantKeeper ante.FeegrantKeeper
36+
SignModeHandler *txsigning.HandlerMap
37+
SigGasConsumer func(meter storetypes.GasMeter, sig signing.SignatureV2, params authtypes.Params) error
38+
39+
AccountKeeper feemarketante.AccountKeeper
40+
BankKeeper feemarketante.BankKeeper
3141
Codec codec.BinaryCodec
3242
IBCkeeper *ibckeeper.Keeper
3343
StakingKeeper *stakingkeeper.Keeper
@@ -85,6 +95,9 @@ func NewAnteHandler(opts HandlerOptions) (sdk.AnteHandler, error) {
8595
if UseFeeMarketDecorator {
8696
anteDecorators = append(anteDecorators,
8797
feemarketante.NewFeeMarketCheckDecorator(
98+
opts.AccountKeeper,
99+
opts.BankKeeper,
100+
opts.FeegrantKeeper,
88101
opts.FeeMarketKeeper,
89102
ante.NewDeductFeeDecorator(
90103
opts.AccountKeeper,

app/app.go

+5-8
Original file line numberDiff line numberDiff line change
@@ -315,13 +315,11 @@ func New(
315315

316316
anteHandler, err := quasarante.NewAnteHandler(
317317
quasarante.HandlerOptions{
318-
HandlerOptions: ante.HandlerOptions{
319-
AccountKeeper: app.AccountKeeper,
320-
BankKeeper: app.BankKeeper,
321-
FeegrantKeeper: app.FeeGrantKeeper,
322-
SignModeHandler: txConfig.SignModeHandler(),
323-
SigGasConsumer: ante.DefaultSigVerificationGasConsumer,
324-
},
318+
AccountKeeper: app.AccountKeeper,
319+
BankKeeper: app.BankKeeper,
320+
FeegrantKeeper: app.FeeGrantKeeper,
321+
SignModeHandler: txConfig.SignModeHandler(),
322+
SigGasConsumer: ante.DefaultSigVerificationGasConsumer,
325323
Codec: appCodec,
326324
IBCkeeper: app.IBCKeeper,
327325
StakingKeeper: app.StakingKeeper,
@@ -340,7 +338,6 @@ func New(
340338
postHandlerOptions := PostHandlerOptions{
341339
AccountKeeper: app.AccountKeeper,
342340
BankKeeper: app.BankKeeper,
343-
FeeGrantKeeper: app.FeeGrantKeeper,
344341
FeeMarketKeeper: app.FeeMarketKeeper,
345342
}
346343
postHandler, err := NewPostHandler(postHandlerOptions)

app/post.go

-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ type PostHandlerOptions struct {
1616
AccountKeeper feemarketpost.AccountKeeper
1717
BankKeeper feemarketpost.BankKeeper
1818
FeeMarketKeeper feemarketpost.FeeMarketKeeper
19-
FeeGrantKeeper feemarketpost.FeeGrantKeeper
2019
}
2120

2221
// NewPostHandler returns a PostHandler chain with the fee deduct decorator.
@@ -41,7 +40,6 @@ func NewPostHandler(options PostHandlerOptions) (sdk.PostHandler, error) {
4140
feemarketpost.NewFeeMarketDeductDecorator(
4241
options.AccountKeeper,
4342
options.BankKeeper,
44-
options.FeeGrantKeeper,
4543
options.FeeMarketKeeper,
4644
),
4745
}

go.mod

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/quasar-finance/quasar
22

3-
go 1.22.5
3+
go 1.22.6
44

55
require (
66
cosmossdk.io/api v0.7.5
@@ -34,12 +34,12 @@ require (
3434
github.com/golangci/golangci-lint v1.60.2
3535
github.com/gorilla/mux v1.8.1
3636
github.com/grpc-ecosystem/grpc-gateway v1.16.0
37-
github.com/skip-mev/feemarket v1.0.4
37+
github.com/skip-mev/feemarket v1.1.0
3838
github.com/spf13/cast v1.7.0
3939
github.com/spf13/cobra v1.8.1
4040
github.com/stretchr/testify v1.9.0
4141
google.golang.org/genproto/googleapis/api v0.0.0-20240725223205-93522f1f2a9f
42-
google.golang.org/grpc v1.64.1
42+
google.golang.org/grpc v1.65.0
4343
google.golang.org/protobuf v1.34.2
4444
)
4545

go.sum

+4-4
Original file line numberDiff line numberDiff line change
@@ -1248,8 +1248,8 @@ github.com/sivchari/tenv v1.10.0 h1:g/hzMA+dBCKqGXgW8AV/1xIWhAvDrx0zFKNR48NFMg0=
12481248
github.com/sivchari/tenv v1.10.0/go.mod h1:tdY24masnVoZFxYrHv/nD6Tc8FbkEtAQEEziXpyMgqY=
12491249
github.com/skip-mev/chaintestutil v0.0.0-20240514161515-056d7ba45610 h1:4JlsiRVt/YZOvrKH525T7sZXgEWUEjqSDMwE6fXNbdo=
12501250
github.com/skip-mev/chaintestutil v0.0.0-20240514161515-056d7ba45610/go.mod h1:kB8gFZX07CyJnw8q9iEZijI3qJTIe1K/Y++P5VGkrcg=
1251-
github.com/skip-mev/feemarket v1.0.4 h1:OPZ9D0tlDUa55n+HIjE2DgL+geMOwcDwUXTYdz4ig9Y=
1252-
github.com/skip-mev/feemarket v1.0.4/go.mod h1:lszt7zGEEActbDYq1hOKogQvfCsnLEHH5113LwgmYcE=
1251+
github.com/skip-mev/feemarket v1.1.0 h1:3z/3Mplmk4t1C/IjghC+OE361L9n8dR3Xr7bXIcS7ec=
1252+
github.com/skip-mev/feemarket v1.1.0/go.mod h1:CVsCaHxJDK4y271c1Dan6Z8G2QaOyWJLoSBnDEPon40=
12531253
github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d/go.mod h1:OnSkiWE9lh6wB0YB77sQom3nweQdgAjqCqsofrRNTgc=
12541254
github.com/smartystreets/goconvey v1.6.4/go.mod h1:syvi0/a8iFYH4r/RixwvyeAJjdLS9QV7WQ/tjFTllLA=
12551255
github.com/soheilhy/cmux v0.1.4/go.mod h1:IM3LyeVVIOuxMH7sFAkER9+bJ4dT7Ms6E4xg4kGIyLM=
@@ -2026,8 +2026,8 @@ google.golang.org/grpc v1.48.0/go.mod h1:vN9eftEi1UMyUsIF80+uQXhHjbXYbm0uXoFCACu
20262026
google.golang.org/grpc v1.49.0/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCDK+GI=
20272027
google.golang.org/grpc v1.50.0/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCDK+GI=
20282028
google.golang.org/grpc v1.50.1/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCDK+GI=
2029-
google.golang.org/grpc v1.64.1 h1:LKtvyfbX3UGVPFcGqJ9ItpVWW6oN/2XqTxfAnwRRXiA=
2030-
google.golang.org/grpc v1.64.1/go.mod h1:hiQF4LFZelK2WKaP6W0L92zGHtiQdZxk8CrSdvyjeP0=
2029+
google.golang.org/grpc v1.65.0 h1:bs/cUb4lp1G5iImFFd3u5ixQzweKizoZJAwBNLR42lc=
2030+
google.golang.org/grpc v1.65.0/go.mod h1:WgYC2ypjlB0EiQi6wdKixMqukr6lBc0Vo+oOgjrM5ZQ=
20312031
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.1.0/go.mod h1:6Kw0yEErY5E/yWrBtf03jp27GLLJujG4z/JK95pnjjw=
20322032
google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8=
20332033
google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0=

0 commit comments

Comments
 (0)