Skip to content

Commit 7ee81a1

Browse files
feat(create-quasar): use pnpm-workspace.yaml instead of npmrc (#18219)
* feat(create-quasar): use pnpm-workspace.yaml instead of npmrc the options except shamefully-hoist now have the defaults we want, so we drop them as well * feat(create-quasar): mark pnpm v10 as the minimum in package.json > engines * ci(create-quasar): ensure create-test-project correctly applies prompt overrides * chore(create-quasar): fix lint error * ci(create-quasar): further fix create-test-project
1 parent cef528a commit 7ee81a1

File tree

14 files changed

+23
-25
lines changed

14 files changed

+23
-25
lines changed

create-quasar/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"node": ">=16"
2828
},
2929
"scripts": {
30-
"lint": "eslint --flag unstable_config_lookup_from_file --fix",
30+
"lint": "eslint --flag v10_config_lookup_from_file --fix",
3131
"create-test-project": "tsx scripts/create-test-project.ts"
3232
},
3333
"dependencies": {

create-quasar/scripts/create-test-project.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,12 @@ export async function createProject({ scriptType, appEngine, packageManager }: C
4141
packageManager,
4242
});
4343

44+
// We are overriding .override() as every call overrides the previous overrides (too many overrides :D)
45+
// This way, we guarantee that even if we call prompts.override() in create-quasar code, our values remain
46+
prompts.override = () => {};
47+
// Remove all extra arguments to avoid interfering with the index.js script
48+
process.argv = process.argv.slice(0, 2);
49+
4450
await import('../index.js');
4551
}
4652

create-quasar/templates/app/quasar-v2/js-vite-2/BASE/_.npmrc

Lines changed: 0 additions & 5 deletions
This file was deleted.

create-quasar/templates/app/quasar-v2/js-vite-2/BASE/_package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"engines": {
4545
"node": "^28 || ^26 || ^24 || ^22 || ^20",
4646
"npm": ">= 6.13.4",
47-
"yarn": ">= 1.21.1"
47+
"yarn": ">= 1.21.1",
48+
"pnpm": ">= 10.0.0"
4849
}
4950
}
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# https://pnpm.io/settings
2+
shamefullyHoist: true

create-quasar/templates/app/quasar-v2/js-webpack-4/BASE/_.npmrc

Lines changed: 0 additions & 5 deletions
This file was deleted.

create-quasar/templates/app/quasar-v2/js-webpack-4/BASE/_package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
"engines": {
5555
"node": "^28 || ^26 || ^24 || ^22 || ^20 || ^18",
5656
"npm": ">= 6.13.4",
57-
"yarn": ">= 1.21.1"
57+
"yarn": ">= 1.21.1",
58+
"pnpm": ">= 10.0.0"
5859
}
5960
}
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# https://pnpm.io/settings
2+
shamefullyHoist: true

create-quasar/templates/app/quasar-v2/ts-vite-2/BASE/_.npmrc

Lines changed: 0 additions & 5 deletions
This file was deleted.

create-quasar/templates/app/quasar-v2/ts-vite-2/BASE/_package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
"engines": {
4848
"node": "^28 || ^26 || ^24 || ^22 || ^20",
4949
"npm": ">= 6.13.4",
50-
"yarn": ">= 1.21.1"
50+
"yarn": ">= 1.21.1",
51+
"pnpm": ">= 10.0.0"
5152
}
5253
}

0 commit comments

Comments
 (0)