From a85a11991898f00de3abc069431920b763a232aa Mon Sep 17 00:00:00 2001 From: Alex Domingo Date: Mon, 12 Sep 2022 15:55:04 +0200 Subject: [PATCH 1/2] check array length to avoid removing empty list of packages --- ncm-spma/src/main/perl/spma/yum.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ncm-spma/src/main/perl/spma/yum.pm b/ncm-spma/src/main/perl/spma/yum.pm index f7a3249578..75c0f3520b 100644 --- a/ncm-spma/src/main/perl/spma/yum.pm +++ b/ncm-spma/src/main/perl/spma/yum.pm @@ -907,7 +907,9 @@ sub update_pkgs $to_rm = $self->packages_to_remove($wanted); defined($to_rm) or return 0; $self->spare_dependencies($to_rm, $to_install, $error_is_warn); - $tx = $self->schedule(REMOVE, $to_rm); + if (scalar(@$to_rm) > 0) { + $tx = $self->schedule(REMOVE, $to_rm); + } } $tx .= $self->schedule(INSTALL, $to_install); From 3f5fc56ccbcae153b468aa99ff8ba8ed2d51ef8d Mon Sep 17 00:00:00 2001 From: Alex Domingo Date: Tue, 13 Sep 2022 01:01:29 +0200 Subject: [PATCH 2/2] also remove empty lines from output of LEAF_PACKAGES command --- ncm-spma/src/main/perl/spma/yum.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ncm-spma/src/main/perl/spma/yum.pm b/ncm-spma/src/main/perl/spma/yum.pm index 75c0f3520b..5c4accef60 100644 --- a/ncm-spma/src/main/perl/spma/yum.pm +++ b/ncm-spma/src/main/perl/spma/yum.pm @@ -694,7 +694,7 @@ sub packages_to_remove # The leaf set doesn't contain the header lines, which are just # garbage. - my $leaves = Set::Scalar->new(grep($_ !~ m{\s}, split(/\n/, $out))); + my $leaves = Set::Scalar->new(grep($_ !~ m{^$|\s}, split(/\n/, $out))); my $candidates = $leaves-$wanted;