Use cd_or_die function for mandatory directory changes

Copied from build_all_repos

Author: jrha

src/releasing/releaser.sh

@@ -48,7 +48,7 @@ clean_templates() {
 # Commit to template-library-core the removal of obsolete configuration modules
 remove_obsolete_components () {
     (
-        cd "${LIBRARY_CORE_DIR}" || echo_error "Failed to change directory to '$LIBRARY_CORE_DIR'"
+        cd_or_die "${LIBRARY_CORE_DIR}"
         #FIXME: ideally should check that there is only deleted files left
         git add -A .
         git commit -m 'Remove obsolete components'
@@ -61,12 +61,12 @@ publish_templates() {
     echo_info "Publishing Component Templates"
     type=$1
     tag=$2
-    cd "configuration-modules-$1" || echo_error "Failed to change directory to 'configuration-modules-$1'"
+    cd_or_die "configuration-modules-$1"
     git checkout "$tag"
     mvn-c clean compile
     # ugly hack
     if [ -d ncm-metaconfig ]; then
-        cd ncm-metaconfig || echo_error "Failed to change directory to 'ncm-metaconfig'"
+        cd_or_die ncm-metaconfig
         mvn -e clean test
         cd ..
     fi
@@ -77,7 +77,7 @@ publish_templates() {
     cp -r ncm-*/target/pan/components/* "${components_root}"
     cp -r ncm-metaconfig/target/pan/metaconfig/* "${metaconfig_root}"
     git checkout master
-    cd "${LIBRARY_CORE_DIR}" || return
+    cd_or_die "${LIBRARY_CORE_DIR}"
     git add .
     git commit -m "Component templates (${type}) for tag ${tag}"
     cd ..
@@ -139,7 +139,7 @@ update_version_file() {
     fi
     version_template=quattor/client/version.pan
     (
-        cd "$LIBRARY_CORE_DIR" || echo_error "Failed to change directory to '$LIBRARY_CORE_DIR'"
+        cd_or_die "$LIBRARY_CORE_DIR"
 
         cat > ${version_template} <<EOF
 template quattor/client/version;
@@ -157,7 +157,7 @@ tag_repository() {
     repo=$1
     tag=$2
     (
-        cd "$repo" || echo_error "Failed to change directory to '$repo'"
+        cd_or_die "$repo"
         #FIXME: we may want to check that the tag doesn't exist already
         git tag -s -m "Release ${tag}" "${tag}"
         git push origin --tags HEAD
@@ -168,7 +168,7 @@ tag_branches() {
     repo=$1
     version=$2
     (
-        cd "$repo" || echo_error "Failed to change directory to '$repo'"
+        cd_or_die "$repo"
         # Ignore remote HEAD symlink and branches marked as obsolete
         branches=$(git branch -r | grep -v ' -> ' | grep -Ev 'obsolete$' )
         for branch in ${branches}
@@ -204,6 +204,12 @@ function exit_usage {
     exit 3
 }
 
+function cd_or_die {
+    # Change directory or die trying
+    cd "$@" || error 2 "Failed to change directory to $*"
+    return 0
+}
+
 # Check that dependencies required to perform a release are available
 missing_deps=0
 for cmd in {gpg,gpg-agent,git,mvn,createrepo,tar,sed}; do
@@ -253,7 +259,7 @@ if gpg-agent; then
             if [[ ! -d "$r" ]]; then
                 git clone -q "[email protected]:quattor/$r.git"
             fi
-            cd "$r" || echo_error "Failed to change directory to '$r'"
+            cd_or_die "$r"
             if git branch -r | grep -q "$RELEASE"; then
                 git checkout -q "quattor-$RELEASE"
             else
@@ -272,7 +278,7 @@ if gpg-agent; then
         if [[ $prompt == "yes" ]]; then
             for r in $REPOS_MVN; do
                 echo_info "---------------- Releasing $r ----------------"
-                cd "$r" || echo_error "Failed to change directory to '$r'"
+                cd_or_die "$r"
                 mvn_prepare="mvn -e -q -DautoVersionSubmodules=true -Dgpg.useagent=true -Darguments=-Dgpg.useagent=true -B -DreleaseVersion=$VERSION clean release:prepare"
                 if ! $mvn_prepare; then
                     echo_error "RELEASE FAILURE"
@@ -308,7 +314,7 @@ if gpg-agent; then
 
             echo_success "---------------- YUM repositories complete, tagging git repositories ----------------"
 
-            cd "$RELEASE_ROOT/src" || echo_error "Failed to change directory to '$RELEASE_ROOT/src'"
+            cd_or_die "$RELEASE_ROOT/src"
 
             echo_info "---------------- Updating template-library-core  ----------------"
             clean_templates