refactor: config regex validation logic into reusable functions

Author: jescalada

src/config/validators.ts

@@ -17,68 +17,75 @@ export const validateConfig = (config: GitProxyConfig): boolean => {
  * @returns true if the commit configuration is valid, false otherwise
  */
 function validateCommitConfig(config: GitProxyConfig): boolean {
-  if (config.commitConfig?.author?.email?.local?.block) {
-    try {
-      new RegExp(config.commitConfig.author.email.local.block);
-    } catch (error: unknown) {
-      console.error(
-        `Invalid regular expression for commitConfig.author.email.local.block: ${config.commitConfig.author.email.local.block}`,
-      );
-      return false;
-    }
-  }
+  return (
+    validateConfigRegex(config, 'commitConfig.author.email.local.block') &&
+    validateConfigRegex(config, 'commitConfig.author.email.domain.allow') &&
+    validateConfigRegex(config, 'commitConfig.message.block.patterns') &&
+    validateConfigRegex(config, 'commitConfig.diff.block.patterns') &&
+    validateConfigRegex(config, 'commitConfig.diff.block.providers')
+  );
+}
 
-  if (config.commitConfig?.author?.email?.domain?.allow) {
-    try {
-      new RegExp(config.commitConfig.author.email.domain.allow);
-    } catch (error: unknown) {
-      console.error(
-        `Invalid regular expression for commitConfig.author.email.domain.allow: ${config.commitConfig.author.email.domain.allow}`,
-      );
-      return false;
-    }
+/**
+ * Validates that a regular expression is valid.
+ * @param pattern The regular expression to validate
+ * @param context The context of the regular expression
+ * @returns true if the regular expression is valid, false otherwise
+ */
+function isValidRegex(pattern: string, context: string): boolean {
+  try {
+    new RegExp(pattern);
+    return true;
+  } catch {
+    console.error(`Invalid regular expression for ${context}: ${pattern}`);
+    return false;
   }
+}
 
-  if (config.commitConfig?.message?.block?.patterns) {
-    for (const pattern of config.commitConfig.message.block.patterns) {
-      try {
-        new RegExp(pattern);
-      } catch (error: unknown) {
-        console.error(
-          `Invalid regular expression for commitConfig.message.block.patterns: ${pattern}`,
-        );
-        return false;
+/**
+ * Validates that a value in the configuration is a valid regular expression.
+ * @param config The configuration to validate
+ * @param path The path to the value to validate
+ * @returns true if the value is a valid regular expression, false otherwise
+ */
+function validateConfigRegex(config: GitProxyConfig, path: string): boolean {
+  const getValueAtPath = (obj: unknown, path: string): unknown => {
+    return path.split('.').reduce((current, key) => {
+      if (current == null || typeof current !== 'object') {
+        return undefined;
       }
-    }
+      return (current as Record<string, unknown>)[key];
+    }, obj);
+  };
+
+  const value = getValueAtPath(config, path);
+
+  if (!value) return true;
+
+  if (typeof value === 'string') {
+    return isValidRegex(value, path);
   }
 
-  if (config.commitConfig?.diff?.block?.patterns) {
-    for (const pattern of config.commitConfig.diff.block.patterns) {
-      try {
-        new RegExp(pattern);
-      } catch (error: unknown) {
-        console.error(
-          `Invalid regular expression for commitConfig.diff.block.patterns: ${pattern}`,
-        );
-        return false;
-      }
+  if (Array.isArray(value)) {
+    for (const pattern of value) {
+      if (!isValidRegex(pattern, path)) return false;
     }
+    return true;
   }
 
-  if (config.commitConfig?.diff?.block?.providers) {
-    for (const [key, value] of Object.entries(config.commitConfig.diff.block.providers)) {
-      try {
-        new RegExp(value);
-      } catch (error: unknown) {
-        console.error(`Invalid regular expression for commitConfig.diff.block.providers: ${value}`);
-        return false;
-      }
-    }
+  if (typeof value === 'object') {
+    return Object.values(value).every((pattern) => isValidRegex(pattern as string, path));
   }
 
   return true;
 }
 
+/**
+ * Loads and parses a GitProxyConfig object from a given context and loading strategy.
+ * @param context The context of the configuration
+ * @param loader The loading strategy to use
+ * @returns The parsed GitProxyConfig object
+ */
 export async function loadConfig(
   context: string,
   loader: () => Promise<string>,
@@ -87,6 +94,12 @@ export async function loadConfig(
   return parseGitProxyConfig(raw, context);
 }
 
+/**
+ * Parses a raw string into a GitProxyConfig object.
+ * @param raw The raw string to parse
+ * @param context The context of the configuration
+ * @returns The parsed GitProxyConfig object
+ */
 function parseGitProxyConfig(raw: string, context: string): GitProxyConfig {
   try {
     return Convert.toGitProxyConfig(raw);