When trying to GET an unexisting item, a 200-OK is returned even if the file doesn't exist

[ktecho]

To Reproduce
Trying to do this:

const url = `${serverUrl}/random_sha256`;
const response = await fetch(url, { method: 'HEAD' });

either with HEAD of GET will return 200-OK. I think the problem is that the server is returning a picture correctly:

[quentintaranpino]

Yes, I’m aware that it always returns 200. This is intentional because if I return 404 along with the "not found" image, many Nostr clients display an error on the screen instead of the fallback image. So far, I haven’t found another way to "force" this image in all scenarios.

I also know that in the case of a file, video, or other file types, this behavior is not ideal either. For version 0.7.0, a dynamically generated "not found" file will be returned for each accepted file type. I’m experimenting with it.

[ktecho]

Yeah, maybe an option in Setup to choose the behaviour, because right now there isn't a way to know if a file is present in the server in a programatical way, right?

[Giszmo]

It looks like an easy fix. Change a number here. This might not be desirable for all users but if it's helpful for you, @ktecho, ...

As for the project merging this: I think it should signal 404 or provide an endpoint that allows checking availability of files. As @ktecho implied, as a compromise it could return the 404-image with 200 status on GET but the 404 status on HEAD.

[quentintaranpino]

It looks like an easy fix. Change a number here. This might not be desirable for all users but if it's helpful for you, @ktecho, ...

As for the project merging this: I think it should signal 404 or provide an endpoint that allows checking availability of files. As @ktecho implied, as a compromise it could return the 404-image with 200 status on GET but the 404 status on HEAD.

Yeah, maybe an option in Setup to choose the behaviour, because right now there isn't a way to know if a file is present in the server in a programatical way, right?

You can use HEAD/ or HEAD/<hash.ext> endpoint described here: https://github.com/hzrd149/blossom/blob/cashu-payments/buds/01.md

Example:

(Exist): https://cdn.nostrcheck.me/3552b34d8efe9a366eceda3e06802f18f2ade6fc693e83e51f96b3e9f0a7ce60.webp

(Not exist): https://cdn.nostrcheck.me/3552b34d8efe9a366eceda3e06802f18f2ade6fc693e83e51f96b3e9f0a7ce61.webp

Test with curl:

curl -L -I 'https://cdn.nostrcheck.me/3552b34d8efe9a366eceda3e06802f18f2ade6fc693e83e51f96b3e9f0a7ce61.webp'
curl -L -I 'https://cdn.nostrcheck.me/3552b34d8efe9a366eceda3e06802f18f2ade6fc693e83e51f96b3e9f0a7ce60.webp'

[ktecho]

Interesting that it works perfectly in your server. In localhost (docker), I can do this:

curl -L -I 'http://localhost:3000/3552b34d8efe9a366eceda3e06802f17f2ade6fc693e83e51f96c3e9f0a7ce64'

and I always get this, no matter the hash I put there:

HTTP/1.1 200 OK

[ktecho]

But if I try this:

curl -L -I 'http://localhost:3000/3552b34d8e'

I get this, probably because not enough characters:

HTTP/1.1 404 Not Found

[Giszmo]

@ktecho which version are you running locally and how?

[ktecho]

I was using the docker version for 0.6.0. I'll try to install it locally, even if I prefer to using the docker version for its cleanlyness...

The problem is clearly reflected in the logs:

INFO - RES -> 200 Not Found - /3552b34d8efe9a366eceda3e06802f17f2ade6fc693e83e51f96c3e9f0a7ce65 | Returning not found media file. 172.25.0.1.

In HTTP, Not Found is 404, while 200 is just the opposite (Found).

The specific problem is here, but there are others like "banned - 200".

[Giszmo]

@ktecho I only asked for the version so the team can reproduce and fix it for that version or advise how to fix it via some config.

[ktecho]

Yeah, I just wanted to provide more information on where the problem is, in case it helps to fix it.