ci: run go fix as part of the lint workflow

Author: marten-seemann

.github/workflows/golangci-lint.yml .github/workflows/lint.yml.github/workflows/golangci-lint.yml renamed to .github/workflows/lint.yml

@@ -20,7 +20,11 @@ jobs:
       - uses: actions/setup-go@v6
         with:
           go-version: ${{ matrix.go }}
+      - name: Run go fix
+        if: (success() || failure()) && matrix.go == '1.25.x'
+        run: go fix -diff ./...
       - name: golangci-lint
+        if: success() || failure() # run this step even if the previous one failed
         uses: golangci/golangci-lint-action@82606bf257cbaff209d206a39f5134f0cfbfd2ee # v9.2.1
         with:
           version: v2.4.0

qpack_test.go

@@ -41,15 +41,11 @@ func TestEncodeDecode(t *testing.T) {
 // replace one character by a random character at a random position
 func replaceRandomCharacter(s string) string {
 	pos := rand.IntN(len(s))
-	new := s[:pos]
 	for {
-		if c := randomString(1); c != string(s[pos]) {
-			new += c
-			break
+		if c := randomString(1); c != s[pos:pos+1] {
+			return s[:pos] + c + s[pos+1:]
 		}
 	}
-	new += s[pos+1:]
-	return new
 }
 
 func check(t *testing.T, encoded []byte, hf HeaderField) {