services/polkit: dequeue authentication request after it has finished

Popping immediately destroys the purpose of queueing.
Newer requests takes over currently active one.

Signed-off-by: Aditya Alok <dev.aditya.alok@gmail.com>

Author: MrAdityaAlok

changelog/next.md

@@ -1,4 +1,5 @@
 ## Bug Fixes
 
+- Fixed newer polkit requests overtaking currently active one.
 - Fixed ScreencopyView not displaying when only lock surfaces are shown.
 - Fixed WlSessionLockSurface.visible crashing if accessed before backing surface creation.

src/services/polkit/agentimpl.cpp

@@ -133,7 +133,6 @@ void PolkitAgentImpl::activateAuthenticationRequest() {
 	if (this->queuedRequests.empty()) return;
 
 	AuthRequest* req = this->queuedRequests.front();
-	this->queuedRequests.pop_front();
 	qCDebug(logPolkit) << "activating authentication request for action" << req->actionId
 	                   << ", cookie: " << req->cookie;
 
@@ -171,6 +170,10 @@ void PolkitAgentImpl::finishAuthenticationRequest() {
 
 	this->bActiveFlow.value()->deleteLater();
 
+	if (!this->queuedRequests.empty()) {
+		this->queuedRequests.pop_front();
+	}
+
 	if (!this->queuedRequests.empty()) {
 		this->activateAuthenticationRequest();
 	} else {