Skip to content

Commit bd23d3b

Browse files
g-talbotclaude
andcommitted
fix: update indexing service fingerprint constants and nightly fmt
Adding ParquetMergePolicyConfig and ParquetIndexingConfig to IndexingSettings changes the Hash output, which changes the pipeline params fingerprints. Updated the hardcoded test constants. Added a comment explaining how to recompute them when IndexingSettings fields change. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent bcebad1 commit bd23d3b

3 files changed

Lines changed: 16 additions & 6 deletions

File tree

quickwit/quickwit-config/src/lib.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,9 @@ impl ConfigFormat {
230230
}
231231

232232
pub fn parse<T>(&self, payload: &[u8]) -> anyhow::Result<T>
233-
where T: DeserializeOwned {
233+
where
234+
T: DeserializeOwned,
235+
{
234236
match self {
235237
ConfigFormat::Json => {
236238
let mut json_value: JsonValue =

quickwit/quickwit-config/src/merge_policy_config.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,9 @@ impl Default for ParquetMergePolicyConfig {
184184
}
185185

186186
fn parse_human_duration<'de, D>(deserializer: D) -> Result<Duration, D::Error>
187-
where D: Deserializer<'de> {
187+
where
188+
D: Deserializer<'de>,
189+
{
188190
let value: String = Deserialize::deserialize(deserializer)?;
189191
let duration = humantime::parse_duration(&value).map_err(|error| {
190192
de::Error::custom(format!(
@@ -195,7 +197,9 @@ where D: Deserializer<'de> {
195197
}
196198

197199
fn serialize_duration<S>(value: &Duration, s: S) -> Result<S::Ok, S::Error>
198-
where S: Serializer {
200+
where
201+
S: Serializer,
202+
{
199203
let value_str = humantime::format_duration(*value).to_string();
200204
s.serialize_str(&value_str)
201205
}

quickwit/quickwit-indexing/src/actors/indexing_service.rs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1250,9 +1250,13 @@ mod tests {
12501250

12511251
#[tokio::test]
12521252
async fn test_indexing_service_apply_plan() {
1253-
const PARAMS_FINGERPRINT_INGEST_API: u64 = 1637744865450232394;
1254-
const PARAMS_FINGERPRINT_SOURCE_1: u64 = 1705211905504908791;
1255-
const PARAMS_FINGERPRINT_SOURCE_2: u64 = 8706667372658059428;
1253+
// These fingerprints are hashes of IndexConfig + SourceConfig. They
1254+
// change whenever IndexingSettings fields are added/removed. Recompute
1255+
// by temporarily adding a test that prints
1256+
// `indexing_pipeline_params_fingerprint(&index_config, &source_config)`.
1257+
const PARAMS_FINGERPRINT_INGEST_API: u64 = 13743320112697107273;
1258+
const PARAMS_FINGERPRINT_SOURCE_1: u64 = 4583554739263945512;
1259+
const PARAMS_FINGERPRINT_SOURCE_2: u64 = 11653028234524633167;
12561260

12571261
quickwit_common::setup_logging_for_tests();
12581262
let transport = ChannelTransport::default();

0 commit comments

Comments
 (0)