Update OpenTelemetry metrics dependencies#6498
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e616352ced
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| opentelemetry_sdk = { git = "https://github.com/shuheiktgw/opentelemetry-rust", rev = "7cf7d697626a591394d75c1a7efddcb55198caa6" } | ||
| sasl2-sys = { git = "https://github.com/quickwit-oss/rust-sasl/", rev = "085a4c7" } | ||
|
|
||
| [patch."https://github.com/shuheiktgw/metrics"] |
There was a problem hiding this comment.
I understand the patch on opentelemetry but why should your metrics fork be used here?
There was a problem hiding this comment.
palindrom615/metrics-exporter-otel is a fork of metrics-rs/metrics, and I’ve already forked metrics-rs/metrics, so I can’t fork palindrom615/metrics-exporter-otel because GitHub doesn’t allow users to fork the same repo tree multiple times.
But I may just delete my metrics-rs/metrics fork and fork palindrom615/metrics-exporter-otel directly instead, which might simplify things here. Let me try 🙏
Summary
This PR aims to solve the same problem as #6465, but with a different approach. Instead of reimplementing the libraries ourselves, we are opening PRs to fix the issues upstream and patching them on our side until those PRs are merged and released.