Skip to content

Commit 50c071d

Browse files
drernieclaude
andcommitted
address PR review feedback
- Delete wf/main.gallery.nf (referenced deleted nf-core-gallery bucket) - Bump VERSION in README-DEV.md to 0.9.2 to match manifest - Add regression test for OffsetDateTime ISO-8601 serialization (#321) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent fa9373f commit 50c071d

4 files changed

Lines changed: 21 additions & 31 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
- Modernize main*.nf files
77
- Fix Jackson serialization of `java.time.OffsetDateTime` from Nextflow 24.10+ workflow metadata (#321)
88
- Restore working test input package (replace deleted `nf-core-gallery` with `udp-spec/nf-quilt/source`)
9+
- Remove `wf/main.gallery.nf` (referenced the deleted `nf-core-gallery` bucket)
910

1011
## [0.9.1] 2024-12-24
1112

README-DEV.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ From the command-line, do, e.g.:
1515

1616
```bash
1717
export LOG4J_DEBUG=true # for verbose logging
18-
export VERSION=0.9.1
18+
export VERSION=0.9.2
1919
export NXF_PLUGINS_TEST_REPOSITORY=https://github.com/quiltdata/nf-quilt/releases/download/$(VERSION)/nf-quilt-$(VERSION)-meta.json
2020
nextflow run main.nf -plugins nf-quilt@$(VERSION)
2121
```

plugins/nf-quilt/src/test/nextflow/quilt/QuiltProductTest.groovy

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ import nextflow.quilt.jep.QuiltPackage
2828
import java.nio.file.Files
2929
import java.nio.file.Path
3030
import java.nio.file.Paths
31+
import java.time.OffsetDateTime
32+
import java.time.ZoneOffset
3133
import groovy.transform.CompileDynamic
3234
import spock.lang.Ignore
3335
import spock.lang.IgnoreIf
@@ -95,6 +97,23 @@ class QuiltProductTest extends QuiltSpecification {
9597
product.displayName().replace('%2f', '/') == testURI
9698
}
9799

100+
void 'toJson serializes OffsetDateTime as ISO-8601 string'() {
101+
// Regression test for #321: Nextflow 24.10+ returns OffsetDateTime
102+
// for workflow start/complete; without JavaTimeModule + disabling
103+
// WRITE_DATES_AS_TIMESTAMPS, Jackson would either throw or emit
104+
// a numeric epoch like 1.735040400E9.
105+
given:
106+
OffsetDateTime when = OffsetDateTime.of(2026, 1, 2, 3, 4, 5, 0, ZoneOffset.UTC)
107+
Map map = [start: when, complete: when]
108+
109+
when:
110+
String json = QuiltProduct.toJson(map)
111+
112+
then:
113+
json.contains('"2026-01-02T03:04:05Z"')
114+
!(json =~ /"start"\s*:\s*[0-9]/)
115+
}
116+
98117
void 'should generate solid string for timestamp from now'() {
99118
when:
100119
def now = QuiltProduct.now()

wf/main.gallery.nf

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)