Skip to content

Commit c9f718b

Browse files
drernieclaude
andcommitted
Don't export placeholder WRITE_BUCKET in CI
Removed the 'write-bucket-not-set' default and only export WRITE_BUCKET when .env sets it. Otherwise CI inherits a bogus bucket name, the @IgnoreIf({ env.WRITE_BUCKET == null }) integration-test guard becomes false, and the tests run against a non-existent bucket (NoSuchBucketException). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent c97fce1 commit c9f718b

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

Makefile

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
sinclude .env # create from example.env
2-
export NPR_API_KEY WRITE_BUCKET
2+
# Export to subprocesses (gradle, nextflow). Only export WRITE_BUCKET when
3+
# .env actually sets it; the integration tests use env.WRITE_BUCKET == null
4+
# as their @IgnoreIf signal, so a placeholder default would unmask them in CI.
5+
export NPR_API_KEY
6+
ifneq ($(strip $(WRITE_BUCKET)),)
7+
export WRITE_BUCKET
8+
endif
39
PROJECT ?= nf-quilt
4-
WRITE_BUCKET ?= write-bucket-not-set
510
FRAGMENT ?= &path=.
611
QUERY ?= ?Name=$(USER)&Owner=Kevin+Moore&Date=2023-03-07&Type=CRISPR&Notebook+URL=http%3A%2F%2Fexample.com
712
VERSION ?= $(shell grep "^version" build.gradle | head -1 | awk -F"'" '{ print $$2 }')

0 commit comments

Comments
 (0)