Skip to content

Commit ef33379

Browse files
drernieclaude
andcommitted
address PR review feedback
- Remove broken Makefile targets (coverage, update) that referenced the removed jacoco and com.github.ben-manes.versions plugins - Add missing -plugins flag to s3-test target - Use withInputStream so the manifest FileInputStream is closed deterministically Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 65f7a10 commit ef33379

2 files changed

Lines changed: 6 additions & 13 deletions

File tree

Makefile

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ S3_BASE = s3://$(WRITE_BUCKET)/$(PROJECT)
1212
REPORT ?= ./build/reports/tests/test/index.html
1313

1414
.PHONY: all assemble clean test test-all check rebuild install package release verify fast \
15-
check-env coverage pkg-test dyn-test s3-overlay s3-test s3-in s3-out \
16-
pkg-fail path-input deps update refresh
15+
check-env pkg-test dyn-test s3-overlay s3-test s3-in s3-out \
16+
pkg-fail path-input deps refresh
1717

1818
all: assemble
1919

@@ -52,10 +52,6 @@ rebuild:
5252

5353
test-all: clean test
5454

55-
coverage:
56-
./gradlew jacocoTestReport
57-
open build/reports/jacoco/test/html/index.html || true
58-
5955
install: assemble
6056
./gradlew installPlugin
6157

@@ -81,7 +77,7 @@ s3-overlay: install
8177
nextflow run ./main.nf --plugins $(PROJECT)@$(VERSION) --outdir "$(S3_BASE)/s3-overlay" --input "$(S3_BASE)/s3-in"
8278

8379
s3-test: install
84-
nextflow run ./main.nf --outdir "$(S3_BASE)/s3-test" --input "$(S3_BASE)/s3-in"
80+
nextflow run ./main.nf -profile standard -plugins $(PROJECT)@$(VERSION) --outdir "$(S3_BASE)/s3-test" --input "$(S3_BASE)/s3-in"
8581

8682
s3-in: install
8783
nextflow run ./main.nf -profile standard -plugins $(PROJECT)@$(VERSION) --outdir "$(TEST_URI)" --input "$(S3_BASE)/s3-in"
@@ -106,8 +102,5 @@ path-input: install
106102
deps:
107103
./gradlew -q dependencies
108104

109-
update:
110-
./gradlew dependencyUpdates
111-
112105
refresh:
113106
./gradlew --refresh-dependencies dependencies

src/test/groovy/nextflow/quilt/QuiltPkgTest.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ class QuiltPkgTest extends QuiltSpecification {
5959
]) {
6060
File manifestFile = new File(subPath)
6161
if (manifestFile.exists()) {
62-
def manifest = new Manifest(new FileInputStream(manifestFile))
63-
def attrs = manifest.getMainAttributes()
64-
String version = attrs.getValue('Plugin-Version')
62+
String version = manifestFile.withInputStream { stream ->
63+
new Manifest(stream).getMainAttributes().getValue('Plugin-Version')
64+
}
6565
if (version) {
6666
return version
6767
}

0 commit comments

Comments
 (0)