Commit 14daa72
committed
Attribute every telemetry event to the deployment it concerns
Only three of the emitted analytics events said which Quilt deployment
they happened against, so no per-stack question could be answered from
the data. The host was already handed to the telemetry layer by the
list/detail read paths and went nowhere useful: into a set nothing read,
and into a Sentry scope tag written on the calling thread.
Tracking now takes an EventContext beside the event, so each of the 33
emission sites names the deployment it concerns or explicitly declares
that it concerns none. The context is a struct so later dimensions are
added in one place rather than onto individual event variants. The three
events that declared their own `host` field lose it — one spelling of the
property for every event — with the wire form unchanged, so existing
reports keep working. The never-emitted ErrorOccurred variant goes too.
Package operations receive the package URI the acting surface already
renders from and read its catalog, rather than telemetry re-deriving the
host from local lineage: attribution then names the deployment the user
acted on, costs no I/O, cannot fail, and needs no ordering constraint
against an uninstall destroying the lineage a lookup would read.
Crash reports get the host through the Sentry client's event hook instead
of the scope. Hubs are thread-local and a worker's hub is a snapshot of
the process scope taken when that thread first touched Sentry, so the old
tag reached crashes on one worker and nowhere else. The hook stamps every
outgoing event on any thread, and latest-host-wins replaces the
first-sighting guard.
Deliberately hostless: app launch, first-run setup, package creation (no
remote yet), the local debug/diagnostics actions, and opening a URL in the
browser — one command serves catalog links, docs, local paths and mailto:,
so its URL's host is not necessarily a deployment.1 parent f01b0f3 commit 14daa72
20 files changed
Lines changed: 659 additions & 260 deletions
File tree
- quilt-sync
- src-tauri
- src
- commands
- telemetry
- ui/src
- components
- pages
- installed_package
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
12 | 18 | | |
13 | 19 | | |
14 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
4 | 15 | | |
5 | 16 | | |
6 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
101 | 109 | | |
102 | 110 | | |
103 | 111 | | |
| |||
329 | 337 | | |
330 | 338 | | |
331 | 339 | | |
332 | | - | |
333 | 340 | | |
334 | 341 | | |
335 | 342 | | |
336 | 343 | | |
337 | 344 | | |
338 | 345 | | |
339 | 346 | | |
340 | | - | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
341 | 351 | | |
342 | 352 | | |
343 | 353 | | |
| |||
384 | 394 | | |
385 | 395 | | |
386 | 396 | | |
387 | | - | |
388 | | - | |
389 | | - | |
390 | | - | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
391 | 403 | | |
392 | 404 | | |
393 | 405 | | |
| |||
435 | 447 | | |
436 | 448 | | |
437 | 449 | | |
438 | | - | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
439 | 454 | | |
440 | 455 | | |
441 | 456 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
41 | 45 | | |
42 | 46 | | |
43 | 47 | | |
| |||
46 | 50 | | |
47 | 51 | | |
48 | 52 | | |
| 53 | + | |
49 | 54 | | |
50 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
51 | 61 | | |
52 | 62 | | |
53 | 63 | | |
| |||
71 | 81 | | |
72 | 82 | | |
73 | 83 | | |
| 84 | + | |
74 | 85 | | |
75 | | - | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
76 | 92 | | |
77 | 93 | | |
78 | 94 | | |
| |||
100 | 116 | | |
101 | 117 | | |
102 | 118 | | |
| 119 | + | |
103 | 120 | | |
104 | | - | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
105 | 127 | | |
106 | 128 | | |
107 | 129 | | |
| |||
147 | 169 | | |
148 | 170 | | |
149 | 171 | | |
| 172 | + | |
150 | 173 | | |
151 | | - | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
152 | 180 | | |
153 | 181 | | |
154 | 182 | | |
| |||
202 | 230 | | |
203 | 231 | | |
204 | 232 | | |
| 233 | + | |
205 | 234 | | |
206 | 235 | | |
207 | 236 | | |
| |||
210 | 239 | | |
211 | 240 | | |
212 | 241 | | |
213 | | - | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
214 | 248 | | |
215 | | - | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
216 | 255 | | |
217 | | - | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
218 | 262 | | |
219 | 263 | | |
220 | 264 | | |
| |||
262 | 306 | | |
263 | 307 | | |
264 | 308 | | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
265 | 313 | | |
266 | 314 | | |
267 | 315 | | |
| |||
270 | 318 | | |
271 | 319 | | |
272 | 320 | | |
| 321 | + | |
273 | 322 | | |
274 | 323 | | |
275 | 324 | | |
| |||
279 | 328 | | |
280 | 329 | | |
281 | 330 | | |
282 | | - | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
283 | 337 | | |
284 | | - | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
285 | 344 | | |
286 | | - | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
287 | 351 | | |
288 | 352 | | |
289 | 353 | | |
| |||
315 | 379 | | |
316 | 380 | | |
317 | 381 | | |
| 382 | + | |
318 | 383 | | |
319 | | - | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
320 | 390 | | |
321 | 391 | | |
322 | 392 | | |
| |||
367 | 437 | | |
368 | 438 | | |
369 | 439 | | |
| 440 | + | |
370 | 441 | | |
371 | | - | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
372 | 448 | | |
373 | 449 | | |
374 | 450 | | |
| |||
416 | 492 | | |
417 | 493 | | |
418 | 494 | | |
419 | | - | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
420 | 503 | | |
421 | 504 | | |
422 | 505 | | |
| |||
459 | 542 | | |
460 | 543 | | |
461 | 544 | | |
462 | | - | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
463 | 549 | | |
464 | 550 | | |
465 | 551 | | |
| |||
490 | 576 | | |
491 | 577 | | |
492 | 578 | | |
493 | | - | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
494 | 587 | | |
495 | 588 | | |
496 | 589 | | |
| |||
539 | 632 | | |
540 | 633 | | |
541 | 634 | | |
| 635 | + | |
542 | 636 | | |
543 | | - | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
544 | 643 | | |
545 | 644 | | |
546 | 645 | | |
| |||
0 commit comments