Keep commit-dialog metadata editor mounted across live-validation refetches

The live-validation LocalResource is read inside the Commit page's Suspense
boundary, so each debounced refetch re-armed the boundary's pending set and a
plain Suspense unmounted the whole CommitContent subtree (including the JSON
editor container) to show its fallback, detaching the editor's DOM and blurring
it on every keystroke. Switch the boundary to Transition so it keeps the
already-rendered children mounted while later resource loads are pending; the
editor now mounts once per dialog open and keeps focus through validation
round-trips. Initial load still shows the spinner fallback once.

Author: fiskus

quilt-sync/ui/src/pages/commit.rs

@@ -33,8 +33,19 @@ pub fn Commit() -> impl IntoView {
         async move { commands::get_commit_data(namespace).await }
     });
 
+    // A `Transition` (not `Suspense`) is deliberate: the live-validation
+    // `LocalResource` in `CommitContent` is read (via `live_violations`) inside
+    // this boundary's reactive scope, so reading it registers the resource with
+    // this boundary's `SuspenseContext` — and every debounced refetch re-arms
+    // that pending set. Under a plain `Suspense` the re-armed pending state flips
+    // the boundary back to its fallback, which unmounts the whole `CommitContent`
+    // subtree — including the JSON editor's container `<div>` — detaching it from
+    // the DOM and blurring the metadata editor on every keystroke. `Transition`
+    // keeps the already-rendered children mounted while later resource loads are
+    // pending (it only shows the fallback on the initial load), so the editor is
+    // mounted once per dialog open and validation round-trips never touch its DOM.
     view! {
-        <Suspense fallback=move || {
+        <Transition fallback=move || {
             view! {
                 <Layout breadcrumbs=vec![] notification=notification ui_locked=ui_locked>
                     <Spinner />
@@ -73,7 +84,7 @@ pub fn Commit() -> impl IntoView {
                     }
                 }
             })}
-        </Suspense>
+        </Transition>
     }
 }