Add type-erased TLS metadata to rustls handshake data#2670
Open
iadev09 wants to merge 2 commits into
Open
Conversation
djc
reviewed
Jun 5, 2026
iadev09
force-pushed
the
tls-version-cipher-metadata
branch
2 times, most recently
from
9bad3a2 to
5e9ed13
Compare
djc
approved these changes
Jun 5, 2026
iadev09
force-pushed
the
tls-version-cipher-metadata
branch
from
5e9ed13 to
912f785
Compare
Member
|
Please rebase instead of adding merge commits. |
iadev09
force-pushed
the
tls-version-cipher-metadata
branch
from
3dca192 to
364beb7
Compare
Author
|
Rebased. |
iadev09
force-pushed
the
tls-version-cipher-metadata
branch
from
364beb7 to
d85ab6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2662.
This adds the negotiated TLS protocol version and cipher suite to rustls
HandshakeDataas type-erased values (Box<dyn Any>).I also extended the existing
alpn_successtest to cover the new metadata.