Skip to content

Commit ca4fdfb

Browse files
authored
[DAEC-14] Fix Slack error not correctly being returned (#11)
1 parent 7a2b584 commit ca4fdfb

4 files changed

Lines changed: 7 additions & 9 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file.
33

44
Preferably use **Added**, **Changed**, **Removed** and **Fixed** topics in each release or unreleased log for a better organization.
55

6+
## [1.0.1](https://github.com/quintoandar/validations-engine/releases/tag/1.0.1)
7+
### Fixed
8+
SlackHelper send_slack_errors method returns the correct Boolean value depending on the success of messages.
69
## [1.0.0](https://github.com/quintoandar/validations-engine/releases/tag/1.0.0)
710
### Added
811
First modules and entities of Validations Engine package.

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[bumpversion]
2-
current_version = 0.1.0
2+
current_version = 1.0.1
33
commit = True
44
tag = True
55

setup.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from setuptools import setup, find_packages
22

33
__package_name__ = "validations_engine"
4-
__version__ = "1.0.0"
4+
__version__ = "1.0.1"
55
__repository_url__ = "https://github.com/quintoandar/validations-engine"
66

77

@@ -22,12 +22,7 @@
2222
keywords=["python", "validations", "validations-engine"],
2323
version=__version__,
2424
url=__repository_url__,
25-
packages=find_packages(
26-
include=[
27-
"validations_engine",
28-
"validations_engine.*",
29-
]
30-
),
25+
packages=find_packages(include=["validations_engine", "validations_engine.*"]),
3126
author="QuintoAndar",
3227
install_requires=requirements,
3328
python_requires=">=3.7, <4",

validations_engine/SlackHelper.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def send_slack_errors(error_messages: List[Tuple[str, str]]) -> bool:
2929
f" the webhook url: channel:{channel}, payload:{payload},"
3030
f" error: {e}"
3131
)
32-
response_success |= False
32+
response_success = False
3333
return response_success
3434

3535
@staticmethod

0 commit comments

Comments
 (0)