Analytics.approve_data_collection() returning true even when consent already collected

[obfuscatedgenerated]

I have a basic demo UI for consent collection:

func _ready():
	# don't show if consent already requested
	print(Analytics.should_show_consent_dialog())
	print(Analytics.consent_requested)
	print(Analytics.consent_granted)
	if not Analytics.should_show_consent_dialog():
		print("Skipping consent check...")
		queue_free()


func _on_approve_pressed():
	Analytics.approve_data_collection()
	queue_free()


func _on_deny_pressed():
	Analytics.deny_data_collection()
	queue_free()

No matter what the user presses, the UI will always pop up every time. Analytics.should_show_consent_dialog() prints true, even when the analytics.cfg file records the consent properly and events are being fired. Even if Analytics.consent_granted is true, Analytics.consent_requested is always false at startup.

[obfuscatedgenerated]

Looks like consent_requested is never actually set from the config file:

quiver-analytics-godot-plugin/addons/quiver_analytics/analytics.gd

Line 90 in a19568f

consent_granted = config.get_value("general", "granted")

Should be easy to fix by just adding a line similar to the one linked:

consent_granted = config.get_value("general", "granted")
consent_requested = config.get_value("general", "requested")

[obfuscatedgenerated]

The plugin is also not setting consent_requested when consent is denied because it seems to check if consent is granted as a precondition:

quiver-analytics-godot-plugin/addons/quiver_analytics/analytics.gd

Line 149 in a19568f

if consent_granted:

Not sure the reason behind this but it means that deny data collection only works if it was already approved before!