Skip to content

FLAC's delete() is broken #389

Open
Open
@Bobloblaw09274237009

Description

@Bobloblaw09274237009

Looking at the code to FLAC delete():

from mutagen.flac import FLAC

If you do:
FLAC().delete(fileobj)
this silently fails because because self.tags is always None.

This is confusing beccause in ID3 this behavior works as expected and the tags are deleted from fileobj:
ID3().delete(fileobj)

The documentation is incorrect as it says FLAC's delete() takes *args,**kwargs which it does not.

Additionally, I get an infinite loop when I try to call it:
myflac = open('test.flac','rb').read()
sio = StringIO(); sio.write(myflac); sio.seek(0)
sio2 = StringIO(); sio2.write(sio.read()); sio.seek(0); sio2.seek(0)
fl = FLAC(sio)
fl.delete(sio2); # Infinite loop while writing out to sio2

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions