Skip to content

Commit d411805

Browse files
Apply suggestions from code review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent c06a7e3 commit d411805

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

scripts/python/dtypefront_perf_table.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def method_from_log(text: str, path: Path) -> str:
8484
def parse_profiler_line(text: str, name: str) -> tuple[float, float] | None:
8585
# Example:
8686
# PhotoChemistry::computePhotoChemistry() 7734 6.474 6.474 6.474 33.65%
87-
pattern = re.compile(rf"^{re.escape(name)}\s+\d+\s+([0-9.eE+-]+)\s+([0-9.eE+-]+)\s+([0-9.eE+-]+)\s+([0-9.eE+-]+)%", re.MULTILINE)
87+
pattern = re.compile(rf"^\s*{re.escape(name)}\s+\d+\s+([0-9.eE+-]+)\s+([0-9.eE+-]+)\s+([0-9.eE+-]+)\s+([0-9.eE+-]+)%", re.MULTILINE)
8888
matches = [(float(match.group(3)), float(match.group(4))) for match in pattern.finditer(text)]
8989
if not matches:
9090
return None
@@ -184,7 +184,7 @@ def main() -> None:
184184
print(make_table(metrics))
185185

186186
if args.show_failures:
187-
failures = [(path, row.failed) for path, row in zip(logs, metrics, strict=True) if row.failed is not None]
187+
failures = [(path, row.failed) for path, row in zip(logs, metrics) if row.failed is not None]
188188
if failures:
189189
print("\nFailures:")
190190
for path, failure in failures:

scripts/slurm/dtypefront_gpu_sweep.submit

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ run_case() {
2828

2929
echo "=== $(date -Is) ${tag} ==="
3030
echo "CUDA_VISIBLE_DEVICES=${CUDA_VISIBLE_DEVICES:-unset}"
31-
/usr/bin/time -p "${exe}" "${INPUT_FILE}" dtype_front.plot_radii=0 "$@" \
31+
/usr/bin/time -p "${exe}" "${INPUT_FILE}" "$@" \
3232
> "${LOG_DIR}/${tag}.log" 2>&1
3333
}
3434

0 commit comments

Comments
 (0)