Merge pull request #52 from r-brown/feature/product-review-roadmap

Product Trust & Usability Update

Author: r-brown

index.html

@@ -404,6 +404,27 @@ export function calculateAdvancedStats(this: StatsContext) {
         return sum + pl - adjustment;
     }, 0);
 
+    // Quote coverage over the positions feeding unrealizedPL. A position is
+    // "marked" when its value uses a real price (live quote or user snapshot);
+    // everything else is valued at raw cashflow — open short options count at
+    // full credit — which the UI must disclose next to the headline number.
+    const unrealizedTrades = [...openTrades, ...awaitingCoverageTrades];
+    const markedTrades = unrealizedTrades.filter(trade => {
+        const source = (trade as unknown as Record<string, unknown>).marketPriceSource;
+        return source === 'live' || source === 'snapshot';
+    });
+    const unmarkedTickers = Array.from(new Set(
+        unrealizedTrades
+            .filter(trade => !markedTrades.includes(trade))
+            .map(trade => String(trade.ticker ?? '').trim().toUpperCase())
+            .filter(Boolean)
+    )).sort();
+    const unrealizedQuoteCoverage = {
+        marked: markedTrades.length,
+        total: unrealizedTrades.length,
+        unmarkedTickers
+    };
+
     // Calculate average win and average loss
     const avgWin: DollarAmount = winningTrades.length > 0
         ? winningTrades.reduce((sum, trade) => sum + realizedPLOf(trade), 0) / winningTrades.length
@@ -459,6 +480,7 @@ export function calculateAdvancedStats(this: StatsContext) {
         collateralByTicker,
         realizedPL,
         unrealizedPL,
+        unrealizedQuoteCoverage,
         pendingPremium: parseFloat(pendingPremium.toFixed(2)),
         realizationAnomalies,
         avgWin,

src/calculations/stats.ts

@@ -38,6 +38,8 @@ interface AppConfigShape {
         readonly FINNHUB_CONFIG: string
         readonly FINNHUB_SECRET: string
         readonly GEMINI_MAX_TOKENS: string
+        readonly ANNOUNCEMENT_DISMISSED: string
+        readonly LAST_STRATEGY: string
         readonly LEGACY_KEYS: readonly string[]
     }
     SHARE_CARD: {
@@ -74,6 +76,8 @@ export const APP_CONFIG: AppConfigShape = Object.freeze({
         FINNHUB_CONFIG: 'GammaLedgerFinnhubConfig',
         FINNHUB_SECRET: 'GammaLedgerFinnhubSecret',
         GEMINI_MAX_TOKENS: 'GammaLedgerGeminiMaxTokens',
+        ANNOUNCEMENT_DISMISSED: 'GammaLedgerAnnouncementDismissedId',
+        LAST_STRATEGY: 'GammaLedgerLastStrategy',
         LEGACY_KEYS: Object.freeze([
             'GammaLedgerTrades',
             'GammaLedgerDatabase',

src/core/config.ts

@@ -66,6 +66,21 @@ export function setupImportControls(this: any) {
         });
     }
 
+    const schwabButton = document.getElementById('import-schwab-btn');
+    const schwabInput = document.getElementById('import-schwab-input') as HTMLInputElement | null;
+
+    if (schwabButton && schwabInput) {
+        schwabButton.addEventListener('click', (event) => {
+            event.preventDefault();
+            schwabInput.value = '';
+            schwabInput.click();
+        });
+
+        schwabInput.addEventListener('change', (event) => {
+            this.handleSchwabCsvFileSelection(event);
+        });
+    }
+
     const mergeButton = document.getElementById('import-merge-btn');
     if (mergeButton) {
         mergeButton.addEventListener('click', (event) => {
@@ -131,13 +146,31 @@ export function setupImportControls(this: any) {
                     ofxInput.dispatchEvent(new Event('change', { bubbles: true }));
                 }
             } else if (name.endsWith('.csv')) {
-                // Trigger the Robinhood CSV import path
-                const dt = new DataTransfer();
-                dt.items.add(file);
-                if (robinhoodInput) {
-                    robinhoodInput.files = dt.files;
-                    robinhoodInput.dispatchEvent(new Event('change', { bubbles: true }));
-                }
+                // Sniff the CSV format and route to the right importer;
+                // unknown layouts open the column mapper.
+                file.text().then((text: string) => {
+                    const format = this.detectCsvFormat(text);
+                    const fileName = file.name || 'CSV import';
+                    if (format === 'robinhood') {
+                        return this.importRobinhoodCsvContent(text, { fileName });
+                    }
+                    if (format === 'schwab') {
+                        return this.importSchwabCsvContent(text, { fileName });
+                    }
+                    this.openCsvColumnMapper(text, { fileName });
+                    return undefined;
+                }).catch((error: unknown) => {
+                    console.error('CSV import error:', error);
+                    const message = error instanceof Error ? error.message : 'Unknown error';
+                    this.showNotification(`Failed to import CSV: ${message}`, 'error');
+                    this.appendImportLog({
+                        type: 'error',
+                        message: `Failed to import ${file.name || 'CSV file'}: ${message}`,
+                        timestamp: new Date()
+                    });
+                }).finally(() => {
+                    this.hideLoadingIndicator();
+                });
             } else {
                 this.showNotification('Unsupported file type. Please use OFX, QFX, or CSV files.', 'error');
             }