Skip to content

Commit ca47719

Browse files
authored
odbcConnectionColumns_: s4 dispatch: correctly propagate exact argument (#909)
* odbcConnectionColumns_: s4 dispatch: correctly propagate `exact` argument * Add NEWS update
1 parent cbf507f commit ca47719

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

NEWS.md

+3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# odbc (development version)
22

3+
* SQL Server: Fix issues with argument propagation in bespoke
4+
S4 methods (#906).
5+
36
* Databricks: Fix repeated calls to `dbConnect` (#901).
47

58
# odbc 1.6.1

R/driver-sql-server.R

+2-2
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ setMethod("odbcConnectionColumns_", c("Microsoft SQL Server", "character"),
258258
#' @rdname SQLServer
259259
#' @usage NULL
260260
setMethod("odbcConnectionColumns_", c("Microsoft SQL Server", "SQL"),
261-
function(conn, name, ...) {
262-
odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ...)
261+
function(conn, name, ..., exact = FALSE) {
262+
odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ..., exact = exact)
263263
}
264264
)

R/odbc-connection.R

+2-2
Original file line numberDiff line numberDiff line change
@@ -335,8 +335,8 @@ setMethod("odbcConnectionColumns_", c("OdbcConnection", "character"),
335335
)
336336

337337
setMethod("odbcConnectionColumns_", c("OdbcConnection", "SQL"),
338-
function(conn, name, ...) {
339-
odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ...)
338+
function(conn, name, ..., exact = FALSE) {
339+
odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ..., exact = exact)
340340
}
341341
)
342342

0 commit comments

Comments
 (0)