Skip to content

Conversation

@detule
Copy link
Collaborator

@detule detule commented Dec 15, 2024

Skip SQL server encoding test since OEM driver does not provide for a way to disable "AutoTranslate" feature.

Fixes #869

@detule detule requested a review from simonpcouch December 15, 2024 18:39
@detule
Copy link
Collaborator Author

detule commented Dec 15, 2024

Hey Simon:

This should hopefully fix the issue error with PRO CI workflow. I don't think I have the ability to run that pipeline - if you get a chance to run it manually, we can verify if the test is skipped appropriately.

@detule
Copy link
Collaborator Author

detule commented Dec 15, 2024

Looks like either I broke something unintentionally, or there is an issue with the runner. I'll look into it and ping back when ready.

@detule
Copy link
Collaborator Author

detule commented Dec 15, 2024

Just adding some running commentary: I think our runner started using 24.04 ( was using Ubuntu 22.04 ) - i suspect this is the culprit of the new issue.

Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just locally checked the Pro driver pipeline and saw no issues. Thank you!

CI failures addressed in #876.

Apologies for the delay—spent a good bit of time away for the holidays.🎄

@detule detule merged commit 7b54909 into r-dbi:main Jan 10, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

failures re: independent column name encodings

2 participants