Overhaul viewer-based credentials for Databricks & Snowflake #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
approved these changes
Feb 10, 2025
Collaborator
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
Stellar. Thanks for making this happen!
For the GitHub archeologists: that session argument never made it to CRAN so the removal of that argument only affects users of the dev version of the package.
This commit takes a second stab at the viewer-based credential support added in #853. It contains two major changes: 1. Users no longer need to pass a `session` argument. We figure it out internally instead. This allows users to deploy apps to Connect with no code changes. 2. The underlying code to get these credentials is now hosted in the `connectcreds` package, which also provides a number of nice mocking features we can use in `odbc`'s unit tests. The `connectcreds` implementation is based on the code that this commit removes, though it has a number of improvements as well, so this should be a net win, too. Unit tests and documentation is included. Signed-off-by: Aaron Jacobs <[email protected]>
atheriel
force-pushed
the
use-connectcreds
branch
from
1c1743a to
2b8bd6f
Compare
Collaborator
Author
|
Test failures seem unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit takes a second stab at the viewer-based credential support added in #853.
It contains two major changes:
Users no longer need to pass a
sessionargument. We figure it out internally instead. This allows users to deploy apps to Connect with no code changes.The underlying code to get these credentials is now hosted in the
connectcredspackage, which also provides a number of nice mocking features we can use inodbc's unit tests. Theconnectcredsimplementation is based on the code that this commit removes, though it has a number of improvements as well, so this should be a net win, too.Unit tests and documentation is included.