utils: prefer shlib when looking through unixodbc installations #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
reviewed
Jun 2, 2025
Collaborator
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
I would rather try and understand when we can expect good behavior when linking against the static lib
I think this is reasonable!
Co-authored-by: Simon P. Couch <[email protected]>
Collaborator
Author
|
Thanks @simonpcouch Removed test. Let me know if anything else looks suss. |
Collaborator
|
Going to go ahead and merge so this is resolved on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #919
Tested by:
locate_install_unixodbc(on a mac) when both static and dynamically builtunixodbclibraries were present, versus when only static were found.There is an argument perhaps that we should just revert aba5578 since it didn't fix the CRAN issue and it's potentially causing issues for regular users. I would rather try and understand when we can expect good behavior when linking against the static lib (are issues driver specific, with some OEM drivers behaving better when linking against the static lib versus others?). I don't feel strongly about this though, and can go either way.