diff --git a/NEWS.md b/NEWS.md index 7c53cce9..74a6d6f3 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,8 @@ # odbc (development version) +* SQL Server: Fix issues with argument propagation in bespoke + S4 methods (#906). + * Databricks: Fix repeated calls to `dbConnect` (#901). # odbc 1.6.1 diff --git a/R/driver-sql-server.R b/R/driver-sql-server.R index 5ca9e70e..31a0b969 100644 --- a/R/driver-sql-server.R +++ b/R/driver-sql-server.R @@ -258,7 +258,7 @@ setMethod("odbcConnectionColumns_", c("Microsoft SQL Server", "character"), #' @rdname SQLServer #' @usage NULL setMethod("odbcConnectionColumns_", c("Microsoft SQL Server", "SQL"), - function(conn, name, ...) { - odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ...) + function(conn, name, ..., exact = FALSE) { + odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ..., exact = exact) } ) diff --git a/R/odbc-connection.R b/R/odbc-connection.R index b2c73dc4..38f4d232 100644 --- a/R/odbc-connection.R +++ b/R/odbc-connection.R @@ -335,8 +335,8 @@ setMethod("odbcConnectionColumns_", c("OdbcConnection", "character"), ) setMethod("odbcConnectionColumns_", c("OdbcConnection", "SQL"), - function(conn, name, ...) { - odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ...) + function(conn, name, ..., exact = FALSE) { + odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ..., exact = exact) } )