From 05942fd890483c2a28dda2ab40f4af1b0a128011 Mon Sep 17 00:00:00 2001 From: detule Date: Sun, 30 Mar 2025 14:29:57 +0000 Subject: [PATCH 1/2] odbcConnectionColumns_: s4 dispatch: correctly propagate `exact` argument --- R/driver-sql-server.R | 4 ++-- R/odbc-connection.R | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/R/driver-sql-server.R b/R/driver-sql-server.R index 5ca9e70e..31a0b969 100644 --- a/R/driver-sql-server.R +++ b/R/driver-sql-server.R @@ -258,7 +258,7 @@ setMethod("odbcConnectionColumns_", c("Microsoft SQL Server", "character"), #' @rdname SQLServer #' @usage NULL setMethod("odbcConnectionColumns_", c("Microsoft SQL Server", "SQL"), - function(conn, name, ...) { - odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ...) + function(conn, name, ..., exact = FALSE) { + odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ..., exact = exact) } ) diff --git a/R/odbc-connection.R b/R/odbc-connection.R index b2c73dc4..38f4d232 100644 --- a/R/odbc-connection.R +++ b/R/odbc-connection.R @@ -335,8 +335,8 @@ setMethod("odbcConnectionColumns_", c("OdbcConnection", "character"), ) setMethod("odbcConnectionColumns_", c("OdbcConnection", "SQL"), - function(conn, name, ...) { - odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ...) + function(conn, name, ..., exact = FALSE) { + odbcConnectionColumns_(conn, dbUnquoteIdentifier(conn, name)[[1]], ..., exact = exact) } ) From 28e8d250c53faa0abae8186c8c69098a4da77270 Mon Sep 17 00:00:00 2001 From: detule Date: Sun, 27 Apr 2025 10:42:36 +0000 Subject: [PATCH 2/2] Add NEWS update --- NEWS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS.md b/NEWS.md index 6a85286f..e5137ef0 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,8 @@ # odbc (development version) +* SQL Server: Fix issues with argument propagation in bespoke + S4 methods (#906). + # odbc 1.6.1 * odbc will now automatically find statically built installations of