iterate tests

Author: MichaelChirico

tests/testthat/test-sortuse64.R

@@ -1,4 +1,4 @@
-test_that("orderfin and orderpos work with partial order", {
+with_parameters_test_that("orderfin and orderpos work with partial order", method=1:3, {
   # These were segfaulting due to length(order) < length(table)
   table = as.integer64(c(10, 20, 30, 5, 15, 25))
   order = c(4, 1, 5, 2, 6, 3) # order of table is 5, 10, 15, 20, 25, 30
@@ -10,17 +10,18 @@ test_that("orderfin and orderpos work with partial order", {
   # reference with full order
   full_fin = c(TRUE, TRUE, TRUE, TRUE, TRUE, TRUE, FALSE)
   full_pos = c(4L, 1L, 5L, 2L, 6L, 3L, NA_integer_)
-  expect_identical(orderfin(table, order, x), full_fin)
-  expect_identical(orderpos(table, order, x), full_pos)
+  expect_identical(orderfin(table, order, x, method=method), full_fin)
+  expect_identical(orderpos(table, order, x, method=method), full_pos)
 
   # with partial order, we search in a subset
   partial_fin = c(TRUE, TRUE, TRUE, TRUE, FALSE, FALSE, FALSE)
   partial_pos = c(4L, 1L, 5L, 2L, NA_integer_, NA_integer_, NA_integer_)
-  expect_identical(orderfin(table, partial_order, x), partial_fin)
-  expect_identical(orderpos(table, partial_order, x), partial_pos)
+  expect_identical(orderfin(table, partial_order, x, method=method), partial_fin)
+  expect_identical(orderpos(table, partial_order, x, method=method), partial_pos)
 
-  # user's example, table is not sorted ascending with order
-  # just check for no error
-  expect_identical(orderfin(as.integer64(10:1), 1:3, 8:11, method=1L), c(TRUE, TRUE, TRUE, FALSE))
-  expect_identical(orderpos(as.integer64(10:1), 1:3, 8:11, method=1L), c(1L, 2L, 3L, NA_integer_))
+  # user's example, where `table[order]` is not sorted ascending.
+  # The C functions expect ascending order, so they will fail to find the values.
+  # The test confirms the functions no longer segfault and return a consistent result.
+  expect_identical(orderfin(as.integer64(10:1), 1:3, 8:11, method=method), rep(FALSE, 4L))
+  expect_identical(orderpos(as.integer64(10:1), 1:3, 8:11, method=method), rep(NA_integer_, 4L))
 })