code_highlight() supports long strings and symbols#727
Merged
gaborcsardi merged 5 commits intor-lib:mainfrom Apr 22, 2025
Merged
code_highlight() supports long strings and symbols#727gaborcsardi merged 5 commits intor-lib:mainfrom
gaborcsardi merged 5 commits intor-lib:mainfrom
Conversation
Contributor
Author
|
@gaborcsardi Is there anything I can do to help moving this forward? |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #726
I used a better approach than what I used at the time for prettycode. This is less hacky and solves corner cases that I hadn't looked into back then.
It first looked like
utils::getParseText()could solve the issue but unfortunately it doesn't parse long symbols (used also for names) so this is not enough. Hence I createdget_parse_data()wrappinggetParseDate()and borrowing elements fromutils::getParseText().