bug: `covr::codecov()` should throw an error if unable to upload coverage results to codecov.io

[ALanguillaume]

Description

covr::codecov() should throw an error if unable to upload coverage results to codecov.io

Actual Behaviour

If covr::codecov() fails to upload coverage results to codecov.io it does not throw an error, the corresponding github action is thus marked as successful in github.

The devs are not notify that there was a failure in the workflow.

See this workflow

Expected Behaviour

covr::codecov() throws an error if unable to upload coverage results to codecov.io.
-> gh action workflow fails
-> devs are notified

Additional context

Related to r-lib/actions#822

[roaldarbol]

@ALanguillaume I'm facing this issue. I can see that your test repo has the coverage badge despite the upload failing in the latest test-coverage action. Did you figure out how to solve the issue, or was there another issue?

[ALanguillaume]

@roaldarbol
I am not sure I understand your question.
What is the problem you encountered aside from the silent upload failure ?

[roaldarbol]

Never mind. :-) My issue was that given it was the first time I attempted to use codecov and it failed, I got no badge at all. That resolved after ~10 minutes once codecov caught on to my project.