Add max parameter to git_stat_files()

Author: jeroen

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: gert
 Title: Simple Git Client for R
-Version: 2.3.0
+Version: 2.3.1
 Authors@R: c(
     person("Jeroen", "Ooms", role = c("aut", "cre"), email = "jeroenooms@gmail.com",
       comment = c(ORCID = "0000-0002-4035-0289")),

NEWS

@@ -1,3 +1,6 @@
+2.3.1
+  - git_stat_files() gains a 'max' parameter
+  - Fix function declaration error
 2.3.0
   - Add git_worktree() family of functions (#252)
   - Reformat code with air

R/commit.R

@@ -216,10 +216,11 @@ git_log <- function(ref = "HEAD", max = 100, after = NULL, repo = ".") {
 #' @export
 #' @rdname git_commit
 #' @useDynLib gert R_git_stat_files
-git_stat_files <- function(files, ref = "HEAD", repo = '.') {
+git_stat_files <- function(files, ref = "HEAD", max = NULL, repo = '.') {
   repo <- git_open(repo)
   files <- as.character(files)
-  .Call(R_git_stat_files, repo, files, ref)
+  max <- as.integer(max)
+  .Call(R_git_stat_files, repo, files, ref, max)
 }
 
 assert_string <- function(x) {

man/git_commit.Rd

@@ -310,7 +310,7 @@ SEXP R_git_commit_stats(SEXP ptr, SEXP ref){
   return R_NilValue;
 }
 
-SEXP R_git_stat_files(SEXP ptr, SEXP files, SEXP ref){
+SEXP R_git_stat_files(SEXP ptr, SEXP files, SEXP ref, SEXP max){
   git_commit *parent = NULL;
   git_repository *repo = get_git_repository(ptr);
   git_commit *commit = ref_to_commit(ref, repo);
@@ -327,7 +327,8 @@ SEXP R_git_stat_files(SEXP ptr, SEXP files, SEXP ref){
     INTEGER(changes)[fi] = 0L;
     SET_STRING_ELT(hashes, fi, NA_STRING);
   }
-  while(1) {
+  int max_iter = Rf_length(max) ? Rf_asInteger(max) : 2147483647;
+  for(int iter = 0; iter < max_iter; iter++) {
     git_diff *diff = commit_to_diff(repo, commit);
     if(diff == NULL)
       Rf_error("Failed to get parent commit. Is this a shallow clone?");

src/commit.c

@@ -70,7 +70,7 @@ extern SEXP R_git_stash_drop(SEXP, SEXP);
 extern SEXP R_git_stash_list(SEXP);
 extern SEXP R_git_stash_pop(SEXP, SEXP);
 extern SEXP R_git_stash_save(SEXP, SEXP, SEXP, SEXP, SEXP);
-extern SEXP R_git_stat_files(SEXP, SEXP, SEXP);
+extern SEXP R_git_stat_files(SEXP, SEXP, SEXP, SEXP);
 extern SEXP R_git_status_list(SEXP, SEXP, SEXP);
 extern SEXP R_git_submodule_info(SEXP, SEXP);
 extern SEXP R_git_submodule_init(SEXP, SEXP, SEXP);
@@ -154,7 +154,7 @@ static const R_CallMethodDef CallEntries[] = {
   {"R_git_stash_list",          (DL_FUNC) &R_git_stash_list,          1},
   {"R_git_stash_pop",           (DL_FUNC) &R_git_stash_pop,           2},
   {"R_git_stash_save",          (DL_FUNC) &R_git_stash_save,          5},
-  {"R_git_stat_files",          (DL_FUNC) &R_git_stat_files,          3},
+  {"R_git_stat_files",          (DL_FUNC) &R_git_stat_files,          4},
   {"R_git_status_list",         (DL_FUNC) &R_git_status_list,         3},
   {"R_git_submodule_info",      (DL_FUNC) &R_git_submodule_info,      2},
   {"R_git_submodule_init",      (DL_FUNC) &R_git_submodule_init,      3},