if no remote upstream, return remote address if single; fixes #131 (#263)

* if no remote upstream, return remote address if single; fixes #131

* add tests for #131

* add expected error patterns in tests for #131

* docs: add changelog item

---------

Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>

Author: mpadge

NEWS.md

@@ -1,5 +1,6 @@
 # gert (development version)
 
+- Fix `git_info()` for the case when no upstream is configured (@mpage, #263)
 - `git_branch_create()`: `force` now also applies to the checkout step, allowing branch creation even when local changes would be overwritten (@MichaelChirico, #177).
 - Improve manual pages (@olivroy, #227)
 - Fix badge links in `README.md` (@dpprdan, #189)

src/files.c

@@ -41,6 +41,14 @@ SEXP R_git_repository_info(SEXP ptr){
     git_reference_free(head);
   }
 
+  /* If remote still NA (no upstream configured), use sole remote if exactly one */
+  if(STRING_ELT(remote, 0) == NA_STRING){
+    git_strarray remotes = {0};
+    if(git_remote_list(&remotes, repo) == 0 && remotes.count == 1)
+      SET_STRING_ELT(remote, 0, safe_char(remotes.strings[0]));
+    git_strarray_free(&remotes);
+  }
+
   SEXP out = build_list(8, "path", path, "bare", bare, "head", headref, "shorthand", shorthand,
                     "commit", target, "remote", remote, "upstream", upstream, "reflist", refs);
   UNPROTECT(8);

tests/testthat/test-remotes.R

@@ -6,10 +6,12 @@ test_that("remotes from new repo", {
   expect_error(git_remote_info(repo = repo))
   expect_error(git_remote_refspecs(repo = repo))
   expect_error(git_remote_set_url('https://github.com/foo/bar', repo = repo))
+  expect_error(git_remote_info(repo = repo), "remote 'NA' does not exist")
   expect_error(git_remote_set_pushurl(
     'https://github.com/foo/bar',
     repo = repo
   ))
+  expect_error(git_remote_info(repo = repo), "remote 'NA' does not exist")
   expect_equal(
     git_remote_add(
       'https://github.com/jeroen/webp',
@@ -18,6 +20,9 @@ test_that("remotes from new repo", {
     ),
     'jeroen'
   )
+  # info should work even when no upstream:
+  info <- git_remote_info(repo = repo)
+  expect_equal(info$url, "https://github.com/jeroen/webp")
   git_fetch('jeroen', 'master', repo = repo)
   git_branch_create('master', 'jeroen/master', repo = repo)
   git_branch_create(