Update with_mocked_responses to use new name in docs#715
Merged
hadley merged 1 commit intor-lib:mainfrom Apr 4, 2025
jansim:fix/with-mocked-responses-example
Merged
Update with_mocked_responses to use new name in docs#715hadley merged 1 commit intor-lib:mainfrom jansim:fix/with-mocked-responses-example
with_mocked_responses to use new name in docs#715hadley merged 1 commit intor-lib:mainfrom
jansim:fix/with-mocked-responses-example
Conversation
Member
|
Oops, good catch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for
with_mocked_responsesstill usewith_mockin the examples / return values, which had me confused for a moment when using these today.I think it makes sense to use the non-deprecated name instead? This PR replaces
with_mockwithwith_mocked_responsesin the roxygen comments.