Skip to content

Use base pipe #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hadley merged 1 commit into from
Sep 9, 2025
Merged

Use base pipe #802

hadley merged 1 commit into from
Sep 9, 2025

Conversation

@gaborcsardi
Copy link
Member

@gaborcsardi gaborcsardi commented Sep 9, 2025

A couple of test files still had the magrittr pipe.

@gaborcsardi
Use base pipe
d05da1f 
A couple of test files still had the magrittr pipe.
@hadley hadley merged commit be68041 into main Sep 9, 2025
13 checks passed
@hadley hadley deleted the fix/base-pipe branch September 9, 2025 12:31
@hadley
Copy link
Member

hadley commented Sep 9, 2025

Thanks! I now it's just as easy to fix them yourself, but if you feel like filing issues, these are good for TDD.

@jeroen
Copy link
Member

jeroen commented Sep 9, 2025

Also remove magrittr from suggests, then?

@hadley
Copy link
Member

hadley commented Sep 9, 2025

@jeroen we still re-export the magrittr pipe and don't have a plan to remove that yet (since it might break revdeps/user code). That said, if we did start removing somewhere, it would be reasonable to start with httr2.

schloerke added a commit to schloerke/httr2 that referenced this pull request Oct 9, 2025
@schloerke
Merge branch 'main' into otel
5716aa2 
* main:
  Convert `vignette()` to explicit URL links (r-lib#803)
  Use base pipe (r-lib#802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gaborcsardi @hadley @jeroen