Fix R CMD diagnostic complaints

Author: shikokuchuo

src/mbedtls/library/constant_time_impl.h

@@ -11,10 +11,6 @@
 #if defined(MBEDTLS_BIGNUM_C)
 #include "mbedtls/bignum.h"
 #endif
-#if defined(MBEDTLS_COMPILER_IS_GCC) && (__GNUC__ > 4)
-    #pragma GCC diagnostic push
-    #pragma GCC diagnostic ignored "-Wredundant-decls"
-#endif
 #if defined(MBEDTLS_TEST_CONSTANT_FLOW_MEMSAN) || \
     (defined(MBEDTLS_TEST_CONSTANT_FLOW_VALGRIND) && !defined(MBEDTLS_TEST_CONSTANT_FLOW_ASM))
 #define MBEDTLS_CT_NO_ASM 
@@ -112,16 +108,9 @@ static inline mbedtls_ct_condition_t mbedtls_ct_bool(mbedtls_ct_uint_t x)
     return (mbedtls_ct_condition_t) x;
 #else
     const mbedtls_ct_uint_t xo = mbedtls_ct_compiler_opaque(x);
-#if defined(_MSC_VER)
-#pragma warning( push )
-#pragma warning( disable : 4146 )
-#endif
     mbedtls_ct_int_t y = (-xo) | -(xo >> 1);
     y = (((mbedtls_ct_uint_t) y) >> (MBEDTLS_CT_SIZE - 1));
     return (mbedtls_ct_condition_t) (-y);
-#if defined(_MSC_VER)
-#pragma warning( pop )
-#endif
 #endif
 }
 static inline mbedtls_ct_uint_t mbedtls_ct_if(mbedtls_ct_condition_t condition,
@@ -390,7 +379,4 @@ static inline mbedtls_ct_condition_t mbedtls_ct_bool_not(mbedtls_ct_condition_t
 {
     return (mbedtls_ct_condition_t) (~x);
 }
-#if defined(MBEDTLS_COMPILER_IS_GCC) && (__GNUC__ > 4)
-    #pragma GCC diagnostic pop
-#endif
 #endif

src/mbedtls/library/platform_util.c

@@ -72,17 +72,11 @@ void mbedtls_platform_zeroize(void *buf, size_t len)
 #if defined(__GNUC__)
 #if defined(__clang__) || (__GNUC__ >= 10)
 #if defined(__clang__)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wvla"
 #elif defined(MBEDTLS_COMPILER_IS_GCC)
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wvla"
 #endif
         asm volatile ("" : : "m" (*(char (*)[len]) buf) :);
 #if defined(__clang__)
-#pragma clang diagnostic pop
 #elif defined(MBEDTLS_COMPILER_IS_GCC)
-#pragma GCC diagnostic pop
 #endif
 #endif
 #endif

src/nng/src/platform/posix/posix_pipe.c

@@ -98,16 +98,13 @@ nni_plat_pipe_open(int *wfd, int *rfd)
 	return (0);
 }
 
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wunused-result"
 void
 nni_plat_pipe_raise(int wfd)
 {
 	char c = 1;
 
-	(void) write(wfd, &c, 1);
+	if (write(wfd, &c, 1)) {};
 }
-#pragma GCC diagnostic pop
 
 void
 nni_plat_pipe_clear(int rfd)