Migrate to NNG 2.0-compatible APIs #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
For non-trivial changes to C code, I like to build the tarball locally and run For more substantial changes and prior to release, I will run it through many of the platforms on rhub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NNG 2.0 API is not compatible in quite a few cases, but where the APIs already exist, we should migrate as much as possible beforehand to minimize the changes.
Doing a
recv()usingNNG_FLAG_ALLOCdirectly into a buffer is no longer possible in NNG 2.0. Instead the more 'modern' (and performant) way to do things is vianng_recvmsg().FYI @lionel- this is just the start. The non-compatible changes will be done on a new branch, and we will bundle NNG 2.0 there so that we don't need to maintain multiple code paths for compatibility.