Hide "Loading metadata database" progress bar using `pkg.show_progress` option

[pawelru]

Even if it's not documented - many packages make use of pkg.show_progress option to enable/disable progress bars. This package is no exception and it is used e.g. here:

pkgcache/R/progress-bar.R

Line 7 in 42e8249

if (isTRUE(getOption("pkg.show_progress", FALSE))) {

But unfortunately not everywhere and there is one little guy that still does not use it:

pkgcache/R/metadata-cache.R

Lines 607 to 615 in 42e8249

	cmc__load_replica_rds <- function(self, private, max_age) {
	"!!DEBUG Load replica RDS?"
	rds <- private$get_cache_files("replica")$rds
	if (!file.exists(rds)) stop("No replica RDS file in cache")
	time <- file_get_time(rds)
	if (Sys.time() - time > max_age) stop("Replica RDS cache file outdated")
	sts <- cli_process_start("Loading metadata database")

[gaborcsardi]

FWIW you can use suppressMessages() to suppress all messages.

[pawelru]

Thank you for the suggestion. I will use it instead of the option. Please decide what to do with this task. I am ok to close it without fix.

[gaborcsardi]

Well, we use pkg.show_progress for an actual progress bar (off by default) currently, but not for the status messages. It would make sense to be able to suppress those as well, but it would be better to do this from some central place, e.g. in cli. So let's keep this open for now.