Use better wording in expect_setequal() output (#2318)

Fixes #2310.

Author: mcol

NEWS.md

@@ -1,6 +1,7 @@
 # testthat (development version)
 
 * `run_cpp_tests()` no longer accidentally reports that a test has been skipped (#2315).
+* `expect_setequal()` uses better wording in the results (@mcol, #2310).
 
 # testthat 3.3.2
 

R/expect-setequal.R

@@ -50,7 +50,7 @@ expect_setequal_ <- function(msg, act, exp, trace_env = caller_env()) {
     msg_act <- c(
       sprintf("Actual: %s", values(act$val)),
       sprintf("Expected: %s", values(exp$val)),
-      if (length(act_miss)) sprintf("Needs: %s", values(act_miss)),
+      if (length(act_miss)) sprintf("Extra: %s", values(act_miss)),
       if (length(exp_miss)) sprintf("Absent: %s", values(exp_miss))
     )
     fail(c(msg_exp, msg_act), trace_env = trace_env)

tests/testthat/_snaps/expect-named.md

@@ -37,7 +37,7 @@
       ! Expected `x2` to have names "a".
       Actual: "a", "b"
       Expected: "a"
-      Needs: "b"
+      Extra: "b"
 
 ---
 
@@ -48,7 +48,7 @@
       ! Expected `x1` to have names "b".
       Actual: "a"
       Expected: "b"
-      Needs: "a"
+      Extra: "a"
       Absent: "b"
 
 ---

tests/testthat/_snaps/expect-setequal.md

@@ -38,7 +38,7 @@
       ! Expected "actual" to have the same values as "expected".
       Actual: "actual"
       Expected: "expected"
-      Needs: "actual"
+      Extra: "actual"
       Absent: "expected"
 
 ---
@@ -50,7 +50,7 @@
       ! Expected `x` to have the same values as `y`.
       Actual: 1, 2
       Expected: 2
-      Needs: 1
+      Extra: 1
 
 ---
 
@@ -72,7 +72,7 @@
       ! Expected `x` to have the same values as `y`.
       Actual: 1, 2
       Expected: 2, 3
-      Needs: 1
+      Extra: 1
       Absent: 3
 
 ---
@@ -84,7 +84,7 @@
       ! Expected `x` to have the same values as `y`.
       Actual: "a", "a"
       Expected: "b", "b", "b"
-      Needs: "a"
+      Extra: "a"
       Absent: "b"
 
 ---
@@ -118,7 +118,7 @@
       ! Expected `x` to have the same names as `y`.
       Actual: "a", "b"
       Expected: "a"
-      Needs: "b"
+      Extra: "b"
 
 ---