Forward stdout/stderr from parallel tests #2163
Merged
Merged
Conversation
I guess the question here is do we want to forward as we update the number of tests, or only at the end when we report the test failures etc. I can see arguments for either Fixes #2095
Member
|
I am afraid that it will take a bit more than this. We need to read out the output as we go, (nearly) immediately as it happens, because otherwise the pipe between the processes will be full and the subprocess stops. This is possibly already happening in the CI jobs that are stuck. |
Member
Author
|
I was afraid that this solution was too simple. |
Member
Member
|
Member
Author
|
Yeah, that looks perfect to me. Thanks! |
Now that we read out stdout/stderr explicitly, we might read it out before the error is reported from a failed worker startup. Or if a task is a startup and not a test file (`path == NA`), then we put the stdout/stderr aside and use it in the error message.
gaborcsardi
approved these changes
Aug 5, 2025
Member
|
@hadley This is done, I think, if you want to take another look. (I can't formally request a review from you, I guess because you are the original author?) |
hadley
commented
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

(100% pure claude code)
I guess the question here is do we want to forward as we update the number of tests, or only at the end when we report the test failures etc. I can see arguments for either
Fixes #2095