Consider having `expect_snapshot(x, style = "serialize")` go to a binary file

[TimTaylor]

If we ignore the question on whether testing values in this way is appropriate is there a particular motivation to have style = "serialize" create a text representation rather than a binary file? I ask as the text file ends up larger than the binary representation and diffs are not useful for the text representation.

Would you consider having type = "serialize" go to a binary snaps file instead?

[hadley]

I don't think there's much point since you wouldn't be able to get a nice diff, which is the whole point of snapshot files.

[TimTaylor]

I think that's kind of my point. You can't get a nice diff anyway so it's kind of a redundant function at the moment unless I'm missing something. In edition2 we had

expect_known_value(x, file = "bob.rds")

but it seems like there's no obvious replacement (accepting that it is only a couple of lines to roll own approach). Currently best option seems like

local_edition(2)
expect_known_value(x, file = "bob.rds")

[hadley]

Right, it's probably pointless, but I presumably added it because someone asked for it, so there's little value in dropping now.