Skip to content

Commit 3974718

Browse files
mhesselbarthmhesselbarth
authored
Merge pull request #115 from r-spatialecology/main
Update CRAN comments
2 parents 1524997 + c480f2a commit 3974718

File tree

1 file changed

+87
-84
lines changed

1 file changed

+87
-84
lines changed

‎cran-comments.md

+87-84
Original file line numberDiff line numberDiff line change
@@ -1,84 +1,87 @@
1-
For details changes, please see NEWS.md.
2-
3-
## shar 2.0.2
4-
Update `spatstat` dependency
5-
6-
## shar 2.0.1
7-
Fixing external repo, typo maintainer name
8-
9-
## shar 2.0.0
10-
* Replace `raster` with `terra` and several code changes related to this
11-
* Fixed issue of earlier submission "Unknown, possibly misspelled, fields in DESCRIPTION: 'Remotes'"
12-
13-
## shar 1.3.2
14-
Improvements of existing functions and `spatstat` update
15-
16-
## shar 1.3.1
17-
Bug fixes
18-
19-
## shar 1.3
20-
Improvements of general package structure
21-
22-
## shar 1.2.1
23-
Improvement of existing functions
24-
25-
## shar 1.2
26-
Update `spatstat` dependencies
27-
28-
## shar 1.1.1
29-
Minor improvements and new license
30-
31-
## shar 1.1
32-
Improvements of existing functions
33-
34-
## shar 1.0.1
35-
Some minor improvements to existing functions
36-
37-
## shar 1.0
38-
New functionality and renaming/splitting of some functions
39-
40-
## shar 0.5
41-
Improvements of existing functions
42-
43-
## shar 0.4
44-
Improvements of general package structure
45-
46-
## shar 0.3.1
47-
Some minor bugfixes
48-
49-
## shar 0.3
50-
Some bugfixes and improvements of existing functions as well as new functions
51-
52-
## shar 0.2
53-
Some bugfixes and improvements of existing functions
54-
55-
## Review CRAN submission
56-
1. Thanks. Please omit the redundant "in R".
57-
58-
* Done as suggested
59-
60-
2. Is there some reference about the method you can add in the Description field in the form Authors (year) <doi:.....>?
61-
62-
* Added "Methods are mainly based on Plotkin et al. (2000) <doi:10.1006/jtbi.2000.2158> and Harms et al. (2001) <doi:10.1111/j.1365-2745.2001.00615.x>." to the description field
63-
64-
3. Thanks, we see:
65-
running tests for arch 'i386' ... [320s] OK
66-
running tests for arch 'x64' ... [356s] OK
67-
which is together alreadyv more than 10 min which is the CRAN threshold for a package check. Can you pls simplify the test cases or run less important tests only conditionally if some env var is set that you only define on your machine?
68-
69-
* The test run faster now (checked on win-builder.r-project)
70-
running tests for arch 'i386' ... [152s] OK
71-
running tests for arch 'x64' ... [164s] OK
72-
73-
* Renamed package from `SHAR` to `shar`
74-
75-
## Test environments
76-
* macOS-latest, R: 'release'
77-
* windows-latest, R: 'release'
78-
* ubuntu-latest, R: 'release'
79-
80-
## R CMD check results
81-
0 errors | 0 warnings | 0 note
82-
83-
## Reverse dependencies
84-
There are currently no reverse dependencies.
1+
For details changes, please see NEWS.md.
2+
3+
## shar 2.0.3
4+
Improvements of existing functions
5+
6+
## shar 2.0.2
7+
Update `spatstat` dependency
8+
9+
## shar 2.0.1
10+
Fixing external repo, typo maintainer name
11+
12+
## shar 2.0.0
13+
* Replace `raster` with `terra` and several code changes related to this
14+
* Fixed issue of earlier submission "Unknown, possibly misspelled, fields in DESCRIPTION: 'Remotes'"
15+
16+
## shar 1.3.2
17+
Improvements of existing functions and `spatstat` update
18+
19+
## shar 1.3.1
20+
Bug fixes
21+
22+
## shar 1.3
23+
Improvements of general package structure
24+
25+
## shar 1.2.1
26+
Improvement of existing functions
27+
28+
## shar 1.2
29+
Update `spatstat` dependencies
30+
31+
## shar 1.1.1
32+
Minor improvements and new license
33+
34+
## shar 1.1
35+
Improvements of existing functions
36+
37+
## shar 1.0.1
38+
Some minor improvements to existing functions
39+
40+
## shar 1.0
41+
New functionality and renaming/splitting of some functions
42+
43+
## shar 0.5
44+
Improvements of existing functions
45+
46+
## shar 0.4
47+
Improvements of general package structure
48+
49+
## shar 0.3.1
50+
Some minor bugfixes
51+
52+
## shar 0.3
53+
Some bugfixes and improvements of existing functions as well as new functions
54+
55+
## shar 0.2
56+
Some bugfixes and improvements of existing functions
57+
58+
## Review CRAN submission
59+
1. Thanks. Please omit the redundant "in R".
60+
61+
* Done as suggested
62+
63+
2. Is there some reference about the method you can add in the Description field in the form Authors (year) <doi:.....>?
64+
65+
* Added "Methods are mainly based on Plotkin et al. (2000) <doi:10.1006/jtbi.2000.2158> and Harms et al. (2001) <doi:10.1111/j.1365-2745.2001.00615.x>." to the description field
66+
67+
3. Thanks, we see:
68+
running tests for arch 'i386' ... [320s] OK
69+
running tests for arch 'x64' ... [356s] OK
70+
which is together alreadyv more than 10 min which is the CRAN threshold for a package check. Can you pls simplify the test cases or run less important tests only conditionally if some env var is set that you only define on your machine?
71+
72+
* The test run faster now (checked on win-builder.r-project)
73+
running tests for arch 'i386' ... [152s] OK
74+
running tests for arch 'x64' ... [164s] OK
75+
76+
* Renamed package from `SHAR` to `shar`
77+
78+
## Test environments
79+
* macOS-latest, R: 'release'
80+
* windows-latest, R: 'release'
81+
* ubuntu-latest, R: 'release'
82+
83+
## R CMD check results
84+
0 errors | 0 warnings | 0 note
85+
86+
## Reverse dependencies
87+
There are currently no reverse dependencies.

0 commit comments

Comments
 (0)