🏗️ handle types in R; expect only RealSexp in Rust #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
jdhoffa
changed the title
asbates
reviewed
Jan 10, 2025
jibarozzo
approved these changes
Jan 11, 2025
Contributor
jibarozzo
left a comment
jibarozzo
left a comment
There was a problem hiding this comment.
This seems like a simple and great approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I update
sum_with_threadsto handle type-casting already in the R session. That way, we can already ensure thatRustonly has to deal with Real numbers, simplifying the complexity of the program. This also allows us to leverage the friendly error messages fromR.As explained in #31, this seems to be more idiomatic of the
savvypackage.📦 gains a dependency on the
⚠️ while I was there, I also removed
vctrspackageadd.R(I think this was an artifact of the "first commit")Maybe supersedes #30
Closes #31