Commit b607461
committed
perf(common): drop discarded PeSymbolProvider.parseSymbols in getImportedFunctions
getImportedFunctions() instantiated PeSymbolProvider(None) and called
parseSymbols(lief_result) only to throw the return value away, then
spun up a second PeSymbolProvider(None) just to call parseImports.
parseSymbols walks lief_binary.symbols and builds a function_symbols
dict; with no `self` mutation (it returns the dict), that work is
purely wasted whenever getImportedFunctions is called.
This removes the dead call. parseSymbols still runs from getSymbols()
and from PeSymbolProvider.update(), so symbol parsing is unchanged
for the callers that actually use it. ELF path is untouched.
Validation:
- pytest tests/test* -> 111 passed, 79 subtests passed
- ruff check + format --check clean1 parent 8b6e117 commit b607461
1 file changed
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
84 | 83 | | |
85 | 84 | | |
86 | 85 | | |
| |||
0 commit comments