Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes string extraction by replacing repeated character checks with a pre-computed lookup table. Feedback suggests expanding the table to 256 elements to eliminate redundant range checks in the detect_ascii_len and detect_unicode_len loops, further improving performance.
Owner
Author
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Addresses gemini-code-assist review on PR #30. With a 256-entry table, non-ASCII bytes (>=127) naturally return False, so the explicit char < 127 guard in the detect_ascii_len and detect_unicode_len hot loops becomes redundant. Removing it saves one comparison per loop iteration on the string-detection hot path. https://claude.ai/code/session_01PHLmsRuiwBQJ3n7gvR7Aa5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What
Precomputes printable ASCII character membership once at module import time and uses an integer-indexed lookup table inside
detect_ascii_len()anddetect_unicode_len().🎯 Why
The previous hot-loop condition called
chr(char) in string.printablefor every byte checked. That repeatedly allocated one-character strings and scannedstring.printableduring string detection. The new lookup keeps the same printable-byte semantics while making the inner-loop check constant time with no per-iterationchr()call.📊 Measured Improvement
Measured with a focused in-process benchmark using dummy SMDA reports, 4,096 printable
~characters, warmup, GC disabled during samples, and best-of-seven timing on this Windows checkout. The machine was noisy, so best sample is the most stable comparison point.detect_ascii_lendetect_unicode_len✅ Verification
python -m ruff format --check .python -m ruff check .python -m pytest -q(42 passed, 7 subtests passed)