merge pull request #72 from r4topunk/fix/tv-feed-build

fix(tv): skip /api/tv/feed prerender; drop debug logs

Author: r4topunk

src/app/api/tv/feed/route.ts

@@ -10,9 +10,13 @@ import {
 } from "@/services/farcaster-tv-aggregator";
 import { GNARS_CREATOR_COIN, GNARS_ZORA_HANDLE } from "@/lib/config";
 
-// Let Next.js handle caching via ISR — serves stale response instantly while
-// revalidating in the background. No more synchronous cache rebuilds blocking requests.
-export const revalidate = 3600; // 1 hour
+// Dynamic route — never prerendered at build time. CDN handles caching via
+// the Cache-Control header on the response (see GET below). Keeps the build
+// free of external API calls (Zora, Neynar, subgraph) that can rate-limit.
+export const dynamic = "force-dynamic";
+export const runtime = "nodejs";
+
+const CACHE_CONTROL_HEADER = "public, s-maxage=3600, stale-while-revalidate=86400";
 
 // Gnars addresses (use centralized config)
 const GNARS_COIN_ADDRESS = GNARS_CREATOR_COIN;
@@ -246,8 +250,6 @@ async function fetchCreatorContent(
   creators: QualifiedCreator[],
   loadedAddresses: Set<string>,
 ): Promise<TVItemData[]> {
-  console.log(`[api/tv] Fetching content from ${creators.length} creators...`);
-
   const allItems: TVItemData[] = [];
 
   await runWithConcurrency(
@@ -278,32 +280,24 @@ async function fetchCreatorContent(
             allItems.push(item);
           }
         }
-      } catch (err) {
-        console.warn(`[api/tv] Failed to fetch content for ${creator.handle}:`, err);
+      } catch {
+        // Skip on error — single creator failure shouldn't break the feed
       }
     },
     MAX_CONCURRENT_COIN_FETCHES,
   );
 
-  console.log(`[api/tv] Fetched ${allItems.length} items from creators`);
   return allItems;
 }
 
 /**
  * Fetch GNARS-paired coins from subgraph with concurrency limit
  */
 async function fetchPairedCoins(loadedAddresses: Set<string>): Promise<TVItemData[]> {
-  console.log("[api/tv] Fetching GNARS-paired coins...");
-
   try {
     const pairedCoins = await fetchGnarsPairedCoins({ first: 100 });
 
-    if (!pairedCoins.length) {
-      console.log("[api/tv] No paired coins in subgraph");
-      return [];
-    }
-
-    console.log(`[api/tv] Found ${pairedCoins.length} paired coins, fetching details...`);
+    if (!pairedCoins.length) return [];
 
     const items: TVItemData[] = [];
 
@@ -338,7 +332,6 @@ async function fetchPairedCoins(loadedAddresses: Set<string>): Promise<TVItemDat
       MAX_CONCURRENT_COIN_FETCHES,
     );
 
-    console.log(`[api/tv] Loaded ${items.length} GNARS-paired coins with media`);
     return items;
   } catch (err) {
     const msg = err instanceof Error ? err.message : String(err);
@@ -351,8 +344,6 @@ async function fetchPairedCoins(loadedAddresses: Set<string>): Promise<TVItemDat
  * Fetch Gnars profile content
  */
 async function fetchGnarsProfileContent(loadedAddresses: Set<string>): Promise<TVItemData[]> {
-  console.log("[api/tv] Fetching Gnars profile content...");
-
   try {
     const response = await getProfileCoins({
       identifier: GNARS_PROFILE_HANDLE,
@@ -389,7 +380,6 @@ async function fetchGnarsProfileContent(loadedAddresses: Set<string>): Promise<T
       MAX_CONCURRENT_COIN_FETCHES,
     );
 
-    console.log(`[api/tv] Loaded ${items.length} from Gnars profile`);
     return items;
   } catch (err) {
     console.warn("[api/tv] Failed to fetch Gnars profile:", err);
@@ -435,8 +425,6 @@ async function mapDroposalToTVItem(droposal: {
 
 export async function GET() {
   const startTime = Date.now();
-  console.log("[api/tv] Starting feed fetch...");
-
   const loadedAddresses = new Set<string>();
 
   try {
@@ -505,35 +493,33 @@ export async function GET() {
     });
 
     const elapsed = Date.now() - startTime;
-    console.log(`[api/tv] Feed ready: ${allItems.length} items in ${elapsed}ms`);
-    console.log(
-      `[api/tv] Sources: ${pairedCoins.length} paired, ${creatorContent.length} creators, ${gnarsContent.length} gnars, ${farcasterItems.length} farcaster, ${droposalItems.length} droposals`,
-    );
-    console.log(`[api/tv] Farcaster cache: ${farcasterData.cache.source}`);
-
-    return NextResponse.json({
-      items: allItems,
-      creators: qualifiedCreators.map((c) => ({
-        handle: c.handle,
-        avatarUrl: c.avatarUrl,
-        coinBalance: c.coinBalance,
-        nftBalance: c.nftBalance,
-      })),
-      stats: {
-        total: allItems.length,
-        withVideo: allItems.filter((i) => i.videoUrl).length,
-        withImage: allItems.filter((i) => !i.videoUrl && i.imageUrl).length,
-        gnarsPaired: pairedCoins.length,
-        droposals: droposalItems.length,
-        creatorsCount: qualifiedCreators.length,
-        farcasterItems: farcasterItems.length,
-        farcasterCreators: farcasterData.stats.creators,
-        farcasterCoins: farcasterData.stats.coins,
-        farcasterNfts: farcasterData.stats.nfts,
+
+    return NextResponse.json(
+      {
+        items: allItems,
+        creators: qualifiedCreators.map((c) => ({
+          handle: c.handle,
+          avatarUrl: c.avatarUrl,
+          coinBalance: c.coinBalance,
+          nftBalance: c.nftBalance,
+        })),
+        stats: {
+          total: allItems.length,
+          withVideo: allItems.filter((i) => i.videoUrl).length,
+          withImage: allItems.filter((i) => !i.videoUrl && i.imageUrl).length,
+          gnarsPaired: pairedCoins.length,
+          droposals: droposalItems.length,
+          creatorsCount: qualifiedCreators.length,
+          farcasterItems: farcasterItems.length,
+          farcasterCreators: farcasterData.stats.creators,
+          farcasterCoins: farcasterData.stats.coins,
+          farcasterNfts: farcasterData.stats.nfts,
+        },
+        fetchedAt: new Date().toISOString(),
+        durationMs: elapsed,
       },
-      fetchedAt: new Date().toISOString(),
-      durationMs: elapsed,
-    });
+      { headers: { "Cache-Control": CACHE_CONTROL_HEADER } },
+    );
   } catch (error) {
     console.error("[api/tv] Feed fetch error:", error);
     return NextResponse.json({ error: "Failed to fetch TV feed" }, { status: 500 });

src/services/farcaster-tv-aggregator.ts

@@ -371,8 +371,6 @@ async function fetchNftHolderCandidates(
     return [];
   }
 
-  console.log(`[farcaster-tv] NFT holder candidates from subgraph: ${holders.length}`);
-
   // Resolve wallets to Zora profiles
   const candidates: CandidateCreator[] = [];
 
@@ -408,10 +406,6 @@ async function fetchNftHolderCandidates(
     MAX_CONCURRENT_PROFILE_FETCHES,
   );
 
-  console.log(
-    `[farcaster-tv] NFT holder candidates with Zora profiles: ${candidates.length}`,
-  );
-
   return candidates;
 }
 
@@ -462,10 +456,6 @@ async function fetchQualifiedCreators(): Promise<QualifiedCreator[]> {
 
   const allCandidates = [...coinCandidates, ...nftCandidates];
 
-  console.log(
-    `[farcaster-tv] Candidates: ${coinCandidates.length} from coin holders, ${nftCandidates.length} from NFT holders`,
-  );
-
   // Resolve wallets for all candidates (coin candidates may already have wallets from prior step)
   const candidatesWithWallets = await fetchProfileWallets(allCandidates);
 
@@ -504,7 +494,6 @@ async function fetchQualifiedCreators(): Promise<QualifiedCreator[]> {
   const allowlistMissing = GNARS_CREATOR_ALLOWLIST.filter((h) => !qualifiedHandles.has(h));
 
   if (allowlistMissing.length > 0) {
-    console.log(`[farcaster-tv] Adding ${allowlistMissing.length} allowlisted creators:`, allowlistMissing);
     for (const handle of allowlistMissing) {
       qualifiedCreators.push({
         handle,
@@ -516,16 +505,6 @@ async function fetchQualifiedCreators(): Promise<QualifiedCreator[]> {
     }
   }
 
-  console.log("[farcaster-tv][qualified-creators] Total:", qualifiedCreators.length);
-  for (const creator of qualifiedCreators) {
-    console.log("[farcaster-tv][qualified-creators] Creator:", {
-      handle: creator.handle,
-      wallets: creator.wallets,
-      coinBalance: creator.coinBalance,
-      nftBalance: creator.nftBalance,
-    });
-  }
-
   return qualifiedCreators;
 }
 
@@ -540,55 +519,23 @@ async function fetchFarcasterMatches(
   if (creators.length === 0) return [];
 
   const wallets = creators.flatMap((creator) => creator.wallets);
-  console.log("[farcaster-tv][farcaster-match-start] Qualified creators:", creators.length);
-  console.log("[farcaster-tv][farcaster-match-start] Wallets to Neynar:", wallets);
   const profilesByAddress = useCache
     ? await fetchFarcasterProfilesByAddress(wallets)
     : await fetchFarcasterProfilesByAddressUncached(wallets);
 
-  console.log("[farcaster-tv][farcaster-match-start] Neynar wallet->profile:", profilesByAddress);
-  console.log(
-    "[farcaster-tv] Farcaster wallet matches:",
-    wallets.map((wallet) => {
-      const profile = profilesByAddress[wallet.toLowerCase()];
-      return {
-        wallet,
-        fid: profile?.fid ?? null,
-        username: profile?.username ?? null,
-        followerCount: profile?.followerCount ?? null,
-      };
-    }),
-  );
-
   const matches: FarcasterCreatorMatch[] = [];
 
   for (const creator of creators) {
     const profiles = creator.wallets
       .map((wallet) => profilesByAddress[wallet.toLowerCase()])
       .filter((profile): profile is FarcasterProfile => Boolean(profile));
 
-    if (profiles.length === 0) {
-      console.log("[farcaster-tv] Skipping creator (no Farcaster match):", {
-        handle: creator.handle,
-        wallets: creator.wallets,
-      });
-      continue;
-    }
+    if (profiles.length === 0) continue;
 
     const bestProfile = profiles.sort((a, b) => b.followerCount - a.followerCount)[0];
-    matches.push({
-      profile: bestProfile,
-    });
+    matches.push({ profile: bestProfile });
   }
 
-  console.log(
-    "[farcaster-tv][farcaster-match-start] Final matches (fids):",
-    matches.map((match) => ({
-      fid: match.profile.fid,
-      username: match.profile.username,
-    })),
-  );
-
   return matches;
 }
 
@@ -753,23 +700,7 @@ async function fetchFarcasterHoldings(
   if (matches.length === 0) return { items: [], stats: { creators: 0, coins: 0, nfts: 0 } };
 
   const rankedAll = rankByFollowerCount(matches);
-  console.log(
-    "[farcaster-tv] Farcaster ranking (pre-limit):",
-    rankedAll.map((match, index) => ({
-      rank: index + 1,
-      fid: match.profile.fid,
-      username: match.profile.username,
-      followerCount: match.profile.followerCount,
-    })),
-  );
-
   const ranked = rankedAll.slice(0, MAX_FARCASTER_USERS);
-  if (ranked.length !== rankedAll.length) {
-    console.log("[farcaster-tv] Farcaster ranking truncated:", {
-      total: rankedAll.length,
-      limit: MAX_FARCASTER_USERS,
-    });
-  }
   const farcasterLoadedKeys = new Set<string>();
 
   const items: TVItemData[] = [];
@@ -840,47 +771,10 @@ async function fetchFarcasterHoldings(
         nftCount++;
       }
 
-      const creatorCoinItems = coinItems.filter(Boolean).length;
-      const creatorNftItems = nftItems.length;
-      if (creatorCoinItems === 0 && creatorNftItems === 0) {
-        console.log("[farcaster-tv] Skipping creator (no eligible items):", {
-          fid: match.profile.fid,
-          username: match.profile.username,
-          followerCount: match.profile.followerCount,
-          coinsFetched: coins.length,
-          nftsFetched: nfts.length,
-          coinsAfterFilter: topCoins.length,
-          nftsAfterFilter: topNfts.length,
-        });
-      } else {
-        console.log("[farcaster-tv] Creator included:", {
-          fid: match.profile.fid,
-          username: match.profile.username,
-          followerCount: match.profile.followerCount,
-          coinsFetched: coins.length,
-          nftsFetched: nfts.length,
-          coinsAfterFilter: topCoins.length,
-          nftsAfterFilter: topNfts.length,
-          coinItems: creatorCoinItems,
-          nftItems: creatorNftItems,
-        });
-      }
     },
     MAX_CONCURRENT_FARCASTER_FETCHES,
   );
 
-  console.log(
-    "[farcaster-tv] Final items:",
-    items.map((item) => ({
-      id: item.id,
-      farcasterFid: item.farcasterFid ?? null,
-      farcasterUsername: item.farcasterUsername ?? null,
-      farcasterType: item.farcasterType ?? null,
-      creator: item.creator,
-      coinAddress: item.coinAddress ?? null,
-    })),
-  );
-
   return { items, stats: { creators: ranked.length, coins: coinCount, nfts: nftCount } };
 }
 
@@ -930,20 +824,10 @@ const getCachedFarcasterTVPayload = unstable_cache(
  * - unstable_cache provides cross-request caching with a 15-minute revalidation window.
  */
 export const getFarcasterTVData = reactCache(async (): Promise<FarcasterTVData> => {
-  const callStart = Date.now();
   const lruHit = farcasterTvLru.get(FARCASTER_TV_CACHE_KEY);
-
-  if (lruHit) {
-    const elapsed = Date.now() - callStart;
-    console.log(`[farcaster-tv] LRU hit in ${elapsed}ms`);
-    return { ...lruHit, cache: { source: "lru" } };
-  }
+  if (lruHit) return { ...lruHit, cache: { source: "lru" } };
 
   const payload = await getCachedFarcasterTVPayload();
   farcasterTvLru.set(FARCASTER_TV_CACHE_KEY, payload);
-
-  const elapsed = Date.now() - callStart;
-  console.log(`[farcaster-tv] Cached fetch in ${elapsed}ms (build ${payload.durationMs}ms)`);
-
   return { ...payload, cache: { source: "next" } };
 });