added tests

Author: rabbit0021

db/sqlite.py

@@ -164,9 +164,9 @@ def get_subscriptions_by_publisher(self, conn, publisher_id):
         rows = c.fetchall()
         return [dict(row) for row in rows]
 
-    def add_subscription(self, conn, email, topic, publisher_id, joined_time=None, operation=""):
+    def add_subscription(self, conn, email, topic, publisher_id, joined_time=None, operation="", frequency=3):
         c = conn.cursor()
-        logger.info(f"Adding subscription for email: {email}, topic: {topic}, publisher_id: {publisher_id}, joined_time: {joined_time}")   
+        logger.info(f"Adding subscription for email: {email}, topic: {topic}, publisher_id: {publisher_id}, joined_time: {joined_time}, frequency: {frequency}")   
 
         sub = self.get_subscriptions_by_email_and_topic_and_publisher_id(conn, email, topic, publisher_id); 
 
@@ -185,14 +185,14 @@ def add_subscription(self, conn, email, topic, publisher_id, joined_time=None, o
            if joined_time is None:
                # Let SQLite fill in the default CURRENT_TIMESTAMP
                c.execute("""
-                   INSERT INTO subscriptions (email, topic, publisher_id)
-                   VALUES (?, ?, ?)
-               """, (email, topic, publisher_id))
+                   INSERT INTO subscriptions (email, topic, publisher_id, frequency_in_days)
+                   VALUES (?, ?, ?, ?)
+               """, (email, topic, publisher_id, frequency))
            else:
                c.execute("""
                    INSERT INTO subscriptions (email, topic, publisher_id, joined_time)
-                   VALUES (?, ?, ?, ?)
-               """, (email, topic, publisher_id, joined_time))    
+                   VALUES (?, ?, ?, ?, ?)
+               """, (email, topic, publisher_id, joined_time, frequency))    
 
            logger.info(f"Subscription for {email} addeed successfully")
 

pytest.ini

@@ -1,6 +1,6 @@
 [pytest]
 markers =
     notifications: mark tests that check notifications
-    e2etests: for end to end tests
+    e2e: for end to end tests
     pubs: for scape_pubs cron
     real: send email in real

tests/e2e/e2etests.py

@@ -0,0 +1,78 @@
+import pytest
+from db import enums
+import os
+from datetime import datetime
+from scrape_pubs import scrape_pubs
+from notify import notify
+from send_notifications import process_notifications
+
+@pytest.mark.e2e
+def test_scrape_pubs_techteams(db, dummy_smtp):
+    conn = db.get_connection()
+    assert 0 == 0
+    
+    db.add_publisher(conn, "aws", "techteam")
+    db.add_subscription(conn, "newemail@gmail.com", enums.PublisherCategory.SOFTWARE_ENGINEERING.value, 1)
+
+    scrape_pubs(db, conn)
+    
+    posts = db.get_posts(conn)
+    
+    assert len(posts) > 10
+    
+    notify(db, conn)
+    
+    notifications = db.get_notifications_by_email(conn, "newemail@gmail.com")
+    
+    assert len(notifications) == 0
+    
+    post = posts[0]
+    
+    db.update_post_label(conn, post['id'], enums.PublisherCategory.SOFTWARE_ENGINEERING.value)
+    conn.commit()
+    
+    notify(db, conn)
+    
+    notifications = db.get_notifications_by_email(conn, "newemail@gmail.com")
+    
+    assert len(notifications) == 1
+    notification = notifications[0]
+    assert notification['email'] == "newemail@gmail.com"
+    assert notification['post_url'] == post['url']
+    assert notification['post_title'] == post['title']
+    assert notification['deleted'] == 0
+    
+    process_notifications(db, conn)
+    assert len(dummy_smtp.sent) == 0
+    
+    db.add_subscription(conn, "newemail2@gmail.com", enums.PublisherCategory.SOFTWARE_ENGINEERING.value, 1, frequency=0)
+    conn.commit()
+    
+    notify(db, conn)
+    
+    notifications = db.get_notifications_by_email(conn, "newemail2@gmail.com")
+    
+    assert len(notifications) == 1
+    notification = notifications[0]
+    assert notification['email'] == "newemail2@gmail.com"
+    assert notification['post_url'] == post['url']
+    assert notification['post_title'] == post['title']
+    assert notification['deleted'] == 0
+    
+    process_notifications(db, conn)
+    assert len(dummy_smtp.sent) == 1
+    
+    
+
+
+
+
+
+    
+
+    
+    
+    
+    
+    
+